From: Thomas Gleixner <tglx@linutronix.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: manningc2@actrix.gen.nz, m.neiger@synergie-inf.com,
"'linux-mtd@lists.infradead.org'" <linux-mtd@lists.infradead.org>
Subject: Re: 16 NANDS
Date: Wed, 08 Jan 2003 21:23:57 +0100 [thread overview]
Message-ID: <200301082123.57689.tglx@linutronix.de> (raw)
In-Reply-To: <4752.1042013699@passion.cambridge.redhat.com>
On Wednesday 08 January 2003 09:14, David Woodhouse wrote:
> tglx@linutronix.de said:
> > The functions are not that different, but it's better to have a
> > little duplicated code instead of if (buswitdh == x) then else....
> > crap.
>
> Bear in mind that if/then/else crap can be hidden inside #defines fairly
> effectively, and optimises away perfectly in the case where you compile for
> only one buswidth -- unlike out-of-line function calls.
>
> What Nico did with cfi_read() et al is worth considering.
I have the option already built in to compile for one buswidth only, but if
you want to compile it for 8/16/32 3 different functions give you more code,
but also more speed and more flexibility for code maintainence
--
Thomas
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
next prev parent reply other threads:[~2003-01-08 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-06 22:42 16 NANDS Marc Neiger
2003-01-06 23:03 ` Charles Manning
2003-01-07 19:04 ` Thomas Gleixner
2003-01-08 8:14 ` David Woodhouse
2003-01-08 20:23 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-01-08 21:23 Marc Neiger
2003-01-08 22:03 ` Thomas Gleixner
2003-01-03 10:27 Marc Neiger
2003-01-06 21:15 ` Charles Manning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200301082123.57689.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=m.neiger@synergie-inf.com \
--cc=manningc2@actrix.gen.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox