From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Simon Evans <spse@secret.org.uk>
Cc: linux-mtd@lists.infradead.org
Subject: Re: default readv/writev functions
Date: Tue, 14 Jan 2003 22:45:10 +0100 [thread overview]
Message-ID: <20030114214510.GC19834@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <E18XNfT-0003Sp-00@spoinky.renegade.org.uk>
On Sat, 11 January 2003 15:35:26 +0000, Simon Evans wrote:
>
> I noticed in fs/jffs2/writev.c there is a mtd_fake_writev and a comment
> that it should be in the MTD core. Is the following ok to commit?
>
> diff -u -p -u -r1.32 mtdcore.c
> --- drivers/mtd/mtdcore.c 7 Mar 2002 18:38:10 -0000 1.32
> +++ drivers/mtd/mtdcore.c 11 Jan 2003 12:28:16 -0000
>
> +int default_mtd_writev(struct mtd_info *mtd, const struct iovec *vecs,
> + unsigned long count, loff_t to, size_t *retlen)
> +int default_mtd_readv(struct mtd_info *mtd, struct iovec *vecs,
> + unsigned long count, loff_t from, size_t *retlen)
>
> +EXPORT_SYMBOL(default_mtd_writev);
> +EXPORT_SYMBOL(default_mtd_readv);
>
> diff -u -p -u -r1.37 mtd.h
> --- include/linux/mtd/mtd.h 19 Nov 2002 01:22:31 -0000 1.37
> +++ include/linux/mtd/mtd.h 11 Jan 2003 12:28:17 -0000
>
> +int default_mtd_writev(struct mtd_info *mtd, const struct iovec *vecs,
> + unsigned long count, loff_t to, size_t *retlen);
> +
> +int default_mtd_readv(struct mtd_info *mtd, struct iovec *vecs,
> + unsigned long count, loff_t from, size_t *retlen);
IMHO this is the wrong place. This should go into
drivers/mtd/chips/cfi_cmdset*.c.
Maybe I should comment on the code as well, but I'm lazy tonight. You
can compare it with cfi_cmdset_0003.c, that one should have a working
writev-function.
Jörn
--
Jörn Engel
mailto: joern@wohnheim.fh-wedel.de
http://wohnheim.fh-wedel.de/~joern
Phone: +49 179 6704074
next prev parent reply other threads:[~2003-01-14 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 15:35 default readv/writev functions Simon Evans
2003-01-14 21:45 ` Jörn Engel [this message]
2003-01-14 23:18 ` David Woodhouse
2003-01-15 0:19 ` Jörn Engel
2003-01-15 0:23 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030114214510.GC19834@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
--cc=spse@secret.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox