public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Earl Manning <EManning@PRISMIQ.com>, linux-mtd@lists.infradead.org
Subject: Re: issue with eraseall
Date: Wed, 02 Apr 2003 19:15:56 +0200	[thread overview]
Message-ID: <200304021915.56265.tglx@linutronix.de> (raw)
In-Reply-To: <20030402095500.2672a730.EManning@PRISMIQ.com>

On Wednesday 02 April 2003 17:55, Earl Manning wrote:
> In my implementation I just changed the value written by eraseall to be 8.
> The offending pieces of code are:
>
> 	util/eraseall.c:84
> 	fs/jffs2/wbuf.c:671-675
I don't see a piece of offending code there

util/eraseall.c: 106 ...
		// format for JFFS2
		if (!jffs2) 
			continue;
				
		// write cleanmarker	
--->		if (isNAND) {
			struct mtd_oob_buf oob;
			oob.ptr = (unsigned char *) &cleanmarker;
			oob.start = erase.start;
--->			oob.start += meminfo.oobsize == 16 ? 8 : 6;
--->			oob.length = meminfo.oobsize == 16 ? 8 : 2;
			if (ioctl (fd, MEMWRITEOOB, &oob) != 0) {
				fprintf(stderr, "\n%s: %s: MTD writeoob failure: %s\n", exe_name, 
mtd_device, strerror(errno));
				continue;
			}
		} else {
This is for NOR !
		}


-- 
Thomas
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de

      reply	other threads:[~2003-04-02 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-02 15:55 issue with eraseall Earl Manning
2003-04-02 17:15 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200304021915.56265.tglx@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=EManning@PRISMIQ.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox