From: Bob Miller <rem@osdl.org>
To: torvalds@transmeta.com
Cc: linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.5.66] Convert elan-104nc to to remove check_region().
Date: Wed, 2 Apr 2003 13:43:45 -0800 [thread overview]
Message-ID: <20030402214345.GA17147@doc.pdx.osdl.net> (raw)
Moved the request_region() call to replace check_region() and adds
release_region()'s in the error paths that occure before the old
call to request_region(). NOTE: This patch just updates comments.
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
diff -nru a/drivers/mtd/maps/elan-104nc.c b/drivers/mtd/maps/elan-104nc.c
--- a/drivers/mtd/maps/elan-104nc.c wed apr 2 10:57:40 2003
+++ b/drivers/mtd/maps/elan-104nc.c wed apr 2 10:57:40 2003
@@ -30,8 +30,8 @@
the single flash device is divided into 3 partition which appear as separate
mtd devices.
-linux thinks that the i/o port is used by the pic and hence check_region() will
-always fail. so we don't do it. i just hope it doesn't break anything.
+linux thinks that the i/o port is used by the pic and hence request_region()
+will always fail. so we don't do it. i just hope it doesn't break anything.
*/
#include <linux/module.h>
#include <linux/slab.h>
@@ -227,14 +227,14 @@
}
iounmap((void *)iomapadr);
- release_region(page_io,page_io_size);
+ /* release_region(page_io,page_io_size); */
}
int __init init_elan_104nc(void)
{
/* urg! we use i/o port 0x22 without request_region()ing it */
/*
- if (check_region(page_io,page_io_size) != 0) {
+ if (!request_region(page_io,page_io_size, "elan-104nc flash")) {
printk( kern_err"%s: io ports 0x%x-0x%x in use\n",
elan_104nc_map.name,
page_io, page_io+page_io_size-1 );
@@ -245,12 +245,11 @@
if (!iomapadr) {
printk( kern_err"%s: failed to ioremap memory region\n",
elan_104nc_map.name );
+ /*
+ release_region(page_io,page_io_size);
+ */
return -eio;
}
-
- /*
- request_region( page_io, page_io_size, "elan-104nc flash" );
- */
printk( kern_info"%s: io:0x%x-0x%x mem:0x%x-0x%x\n",
elan_104nc_map.name,
reply other threads:[~2003-04-02 21:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030402214345.GA17147@doc.pdx.osdl.net \
--to=rem@osdl.org \
--cc=linux-mtd@lists.infradead.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox