From: Thomas Gleixner <tglx@linutronix.de>
To: llandre <r&d@wawnet.biz>, linux-mtd@lists.infradead.org
Cc: Andrea Scian <andrea.scian@wawnet.biz>
Cc: Matteo Bortolin <matteo.bortolin@wawnet.biz>
Subject: Re: Bug in nand_select_chip?
Date: Wed, 17 Mar 2004 17:05:28 +0100 [thread overview]
Message-ID: <200403171705.28040.tglx@linutronix.de> (raw)
In-Reply-To: <6.0.1.1.0.20040317161859.01f80e70@dns.struinfo.it>
On Wednesday 17 March 2004 16:44, llandre wrote:
> Hi,
The calling functions were changed, so there is no problem at all.
> The new function, with chip==0, sets the nCE pin high:
Wrong. SETNCE means set nCE active, which sets the physical pin low.
Therefor it is called _n_CE and SET_N_CE.
> 1) Why did the code change this way?
To handle multiple chips.
> 2) I think the best way to overcome the problem is to define a proprietary
> nand_select_chip function
> in the low-level driver and to make the select_chip pointer in the struct
> nand_chip to point to it. Correct?
You need only a seperate select function, if you have non standard hardware.
The hwcontrol function should be enough adjustment for most boards, where you
have 1 NAND chip to select.
--
Thomas
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
prev parent reply other threads:[~2004-03-17 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-17 15:44 Bug in nand_select_chip? llandre
2004-03-17 15:54 ` David Woodhouse
2004-03-17 16:51 ` llandre
2004-03-17 17:03 ` Thomas Gleixner
2004-03-18 8:11 ` llandre
2004-03-18 9:15 ` Thomas Gleixner
2004-03-18 9:56 ` llandre
2004-03-18 10:56 ` Thomas Gleixner
2004-03-17 16:05 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403171705.28040.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=andrea.scian@wawnet.biz \
--cc=linux-mtd@lists.infradead.org \
--cc=r&d@wawnet.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox