From: Thomas Gleixner <tglx@linutronix.de>
To: llandre <r&d@wawnet.biz>, David Woodhouse <dwmw2@infradead.org>
Cc: Andrea Scian <andrea.scian@wawnet.biz>
Cc: Matteo Bortolin <matteo.bortolin@wawnet.biz>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Bug in nand_select_chip?
Date: Thu, 18 Mar 2004 10:15:58 +0100 [thread overview]
Message-ID: <200403181015.58675.tglx@linutronix.de> (raw)
In-Reply-To: <6.0.1.1.0.20040318084717.01ef8d60@192.168.2.1>
On Thursday 18 March 2004 09:11, llandre wrote:
> > > I fixed the driver as shown in the NAND Flash document:
> > > - nCE pin low when hwcontrol is invoked with NAND_CTL_SETNCE
> > > - nCE pin high when hwcontrol is invoked with NAND_CTL_CLRNCE
> > > and now the driver works with the new MTD code.
> >
> >That's the reason why documents are written. :)
> >
> >But the driver should work with the old code too, as this never changed
> > since we started NAND support in JFFS2.
>
> In my understanding the driver does not work with the old code because
> the old nand_select_chip() implementation called this->hwcontrol(mtd,
> NAND_CTL_CLRNCE),
> with chip==0, setting the nCE pin high.
That's correct, but you unfortunaly relied on code, which was in a heavy
modifciation phase. If you use leading edge code, be aware, that things might
be broken from time to time. The fix for this was committed 10 days after the
first rework.
--
Thomas
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
next prev parent reply other threads:[~2004-03-18 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-17 15:44 Bug in nand_select_chip? llandre
2004-03-17 15:54 ` David Woodhouse
2004-03-17 16:51 ` llandre
2004-03-17 17:03 ` Thomas Gleixner
2004-03-18 8:11 ` llandre
2004-03-18 9:15 ` Thomas Gleixner [this message]
2004-03-18 9:56 ` llandre
2004-03-18 10:56 ` Thomas Gleixner
2004-03-17 16:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403181015.58675.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=andrea.scian@wawnet.biz \
--cc=dwmw2@infradead.org \
--cc=r&d@wawnet.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox