From: tglx@linutronix.de (Thomas Gleixner)
To: Dmitry Konyshev <dmitry.konyshev@auriga.ru>
Cc: linux-mtd@lists.infradead.org
Subject: Re: nand driver bug?
Date: Thu, 15 Apr 2004 09:56:53 +0200 [thread overview]
Message-ID: <200404150956.53532.tglx@linutronix.de> (raw)
In-Reply-To: <407E3E9B.70903@auriga.ru>
On Thursday 15 April 2004 09:49, Dmitry Konyshev wrote:
> Thomas Gleixner wrote:
> >> The driver happens to fall in BUG in nand_select_chip when writing
> >>the last page of a device. It's trying to select_chip in nand_write_ecc
> >>even in case there's nothing left to write.
> >
> >Yep, you're right. I noticed this already and fixed it, but did not yet
> > commit it, as I changed a lot of other things.
> >Should be fixed until tomorrow morning
>
> Any changes should be done in boards' drivers? Fresh CVS version oopses
> in nand_scan.
Yep. I'm writing a short summary at the moment.
Please check the changes in autcpu12.c
We need one additional buffer. The size is oobsize * pages per block, e.g.
blocksize 16384
pagesize 512
= 32 pages per block
* 16 byte oob
= 512 byte buffer
The pointer must be set before calling nand_scan
--
Thomas
________________________________________________________________________
"Free software" is a matter of liberty, not price. To understand the concept,
you should think of "free" as in "free speech,'' not as in "free beer".
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
prev parent reply other threads:[~2004-04-15 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 15:32 nand driver bug? Dmitry Konyshev
2004-04-14 15:44 ` Thomas Gleixner
2004-04-15 7:49 ` Dmitry Konyshev
2004-04-15 7:56 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404150956.53532.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=dmitry.konyshev@auriga.ru \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox