From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout02.sul.t-online.com ([194.25.134.17]) by pentafluge.infradead.org with esmtp (Exim 4.30 #5 (Red Hat Linux)) id 1BNSzo-0001WE-Rt for linux-mtd@lists.infradead.org; Tue, 11 May 2004 09:52:17 +0100 From: tglx@linutronix.de (Thomas Gleixner) To: simon@baydel.com, linux-mtd@lists.infradead.org Date: Tue, 11 May 2004 10:53:00 +0200 References: <200405101732.23971.tglx@linutronix.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200405111053.00541.tglx@linutronix.de> Subject: Re: New NAND interface Reply-To: tglx@linutronix.de List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 10 May 2004 18:35, Simon Haynes wrote: > On Monday 10 May 2004 4:32 pm, Thomas Gleixner wrote: > > On Monday 10 May 2004 16:04, Simon Haynes wrote: > > > I explained, recently, on #mtd, that jffs2 was generating bad crc > > > > Yep. I explained this in > > http://lists.infradead.org/pipermail/linux-mtd/2004-April/009632.html > > Sorry, I should have looked at the archives. This makes it all clear to me. No problem. > > > moment I have fixed this in my NAND driver by specifying autooob with > > > the useecc field set to 0. > > > > Sorry, I was not aware that you have a block driver for SM-FAT. Is this > > driver available anywhere ? > > I have spoken to David about this and I am more than happy to provide the > source to anyone. David, kindly, suggested I send the code to him and he > would have a look before integrating it into the CVS system. I have not > sent it to David as there are restrictions which would not make it suitable > for all. I had planned to remove these and tidy things up but I just have > not made the time. Ok > > > Firstly I am concerned that this might cause problems with other users > > > of the NAND driver. Is there cause for concern ? > > > > AFAIK, are JFFS2 and YAFFS the only clients of NAND driver, except your > > SSFDC module. > > I guess JFFS2 and YAFFS will not bothered about my NAND driver doing auto > placement as they have their own schemes ? Yep. The decision is: Use the caller provided scheme else use the default autoplacement scheme. > > Secondly my SSFDC layer will only work with my NAND driver. > > If you have more questions feel free to ask or let me have a look into > > the code so I can give you more detailed hints. > > As I said, I will supply you the code but I do not expect you to support it > and I do regard it as, incomplete, for gereral use. In general I try to support every known NAND driver client. I would be interested to look into the SSFDC code also to help to fix it so it can be included in the source base. > Thankyou for your support, again :-). At some time I will look into how I > can change the SSFDC layer to interface properly to mtd/nand. As my frig > seems to work for now I am inclined to go with it, unless you think this > otherwise. Cheers Thomas