Re: [PATCH] MTD Maps driver for Sharp LH7a40x

Jun Sun
2004-06-19T00:05:28Z

On Sun, Jun 13, 2004 at 05:54:55PM -0700, Marc Singer wrote:
> On Mon, Jun 14, 2004 at 02:07:48AM +0200, Thomas Gleixner wrote:
> > On Sunday 13 June 2004 23:43, Marc Singer wrote:
> > > I've removed the ununsed, if-def's and commented, code from the
> > > driver.
> > >
> > > As for the C_MAPS loop, there doesn't seem to be a good way to remove
> > > it. Even though there is only one 'chip', we still the map_info
> > > structure for the simple_map_init() and friends. The number of code
> > > code bytes to be saved is nomimal. The change would be to remove the
> > > array references. How do they make the code 'confusing'?
> >
> > That's not a question of code bytes.
> >
> > Why does this code need a for (i = 0; i < C_MAPS;...) loop, if there is only
> > one chip which has to be detected, neglected or whatever and C_MAPS is
> > therefor 1 ?
>
> You originally stated that you thought it made the driver 'confusing'.
> I'm not seeing how this makes it confusing.
>
> >
> > In fact the whole driver could be replaced by command line options.
>
> So can the memory map. The presence of a command line option doesn't
> make it a good idea to use it.
>
> Let me put this a different way. Are you saying that you'll apply the
> patch if I remove the loop?
>

How about just using physmap mapping driver and keep all your
board specific stuff to your board directory? See include/linux/mtd/physmap.h
for more details.

Jun