From: "Thomas Gleixner" <tglx@linutronix.de>
To: Marc Singer <elf@buici.com>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] MTD Maps driver for Sharp LH7a40x
Date: Mon, 14 Jun 2004 02:07:48 +0200 [thread overview]
Message-ID: <200406140207.48467.tglx@linutronix.de> (raw)
In-Reply-To: <20040613214329.GA2282@buici.com>
On Sunday 13 June 2004 23:43, Marc Singer wrote:
> I've removed the ununsed, if-def's and commented, code from the
> driver.
>
> As for the C_MAPS loop, there doesn't seem to be a good way to remove
> it. Even though there is only one 'chip', we still the map_info
> structure for the simple_map_init() and friends. The number of code
> code bytes to be saved is nomimal. The change would be to remove the
> array references. How do they make the code 'confusing'?
That's not a question of code bytes.
Why does this code need a for (i = 0; i < C_MAPS;...) loop, if there is only
one chip which has to be detected, neglected or whatever and C_MAPS is
therefor 1 ?
In fact the whole driver could be replaced by command line options.
--
Thomas
next prev parent reply other threads:[~2004-06-14 0:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-13 21:43 [PATCH] MTD Maps driver for Sharp LH7a40x Marc Singer
2004-06-14 0:07 ` Thomas Gleixner [this message]
2004-06-14 0:54 ` Marc Singer
2004-06-19 0:05 ` Jun Sun
2004-06-19 0:16 ` Thomas Gleixner
2004-06-19 0:38 ` Marc Singer
2004-06-19 8:19 ` Thomas Gleixner
2004-06-19 9:23 ` Russell King - ARM Linux
2004-06-19 9:51 ` Thomas Gleixner
2004-06-19 11:01 ` Russell King - ARM Linux
[not found] <083AB380E3924D4795740AAE9A27DCAB7B89B3@cgy2000.interalia.ca>
2004-06-19 17:03 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2004-06-12 16:47 Marc Singer
2004-06-13 19:34 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406140207.48467.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=elf@buici.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox