From: "Thomas Gleixner" <tglx@linutronix.de>
To: "Dan Brown" <dan_brown@ieee.org>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Towards DiskOnChip support as a NAND driver
Date: Thu, 17 Jun 2004 00:32:09 +0200 [thread overview]
Message-ID: <200406170032.09129.tglx@linutronix.de> (raw)
In-Reply-To: <073c01c453ac$de849e10$0100a8c0@superfortress>
On Wednesday 16 June 2004 16:19, Dan Brown wrote:
> Please realize that this needs a lot more testing. I still haven't gotten
> JFFS2 to run properly with this (though I suspect that may reflect my
> inexperience with JFFS2). Also, the change to nand.h may break other nand
> drivers (though the fix is trivial).
The nand.h change is fixed in nand_ecc.c
> - Modifying JFFS2 to use autooob layout? (Not sure about this)
> - Modifying flash_eraseall to use autooob layout? (Should work OK on
> DOC by coincidence)
Yes, flash_eraseall works by coincidence, but I will look into this.
> - Adding the nand/diskonchip driver into the kernel build system
> instead of the old one
Can you make it optional to use or should we break the code in
drivers/mtd/devices to enforce the development on Dan's code in
drivers/mtd/nand ?
dwmw2 ??
IMHO the current DOC code in drivers/mtd/devices has too many todo's which
inhibit proper usage.
They are partly related to the bad block management. The bad block management
support in the generic nand driver is able to support all types of bad block
tables found on DOC devices.
We fixed the HW ecc problems in nand_base.c today.
It should be not too hard to adjust (I)NFTL to work on the new driver.
Some specialities of the DOC variants which are already working in the old
drivers should be easily copyied to the new one as Dan has already done for
his chip.
Another point is the error correction code. I have a generic reed solomon
library nearly finished which is then usable for all kind of reed solomon
based hw ecc generators. I don't want to make the old drivers use it and I
dont wan't to have duplicate code around.
--
Thomas
_____________________________________________________________________
From slash dot org
"When customers are visiting, engineers are not allowed to wear ties.
That way the customer can tell who is the engineer and who is the
salesman (and therefore whom to believe.). Ties cut off blood flow
to the brain, making it easier for the salesmen to do their jobs."
_____________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
next prev parent reply other threads:[~2004-06-16 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-16 14:19 [PATCH] Towards DiskOnChip support as a NAND driver Dan Brown
2004-06-16 22:32 ` Thomas Gleixner [this message]
2004-06-16 22:46 ` David Woodhouse
2004-06-16 22:50 ` Thomas Gleixner
[not found] <E1BacpZ-0008CJ-KT@canuck.infradead.org>
2004-06-16 16:13 ` Slim
2004-06-16 20:23 ` Dan Brown
2004-06-16 21:47 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406170032.09129.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=dan_brown@ieee.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox