Re: JFFS2 mount time

Gareth Bult (Encryptec)
2004-12-18T20:48:56Z

Like I said, hacked to work [for me] and not to look pretty.

To be honest what's there will do me for now .. although I'd like to
clean it up a little when I get time.

fyi; don't confuse the old and new code.

> o Coding style (Lindent?)

Whatever was there already.

> o Function length

My functions are shorter than the ones that were there, lots can be
cleaned up here.

> o #ifdef MODULE

.. ? I only use it as a module, not of this code was touched.

> o parameters have an insane interface

.. again , parameters and interfaces are all from the original with the
exception of a couple of new routines which mirror existing parameter
lists.

> o ro-devices. the same can be achieved with chmod.

Again, not touched this.

Gareth.

On Sat, 2004-12-18 at 19:11 +0100, Jörn Engel wrote:
> On Sat, 18 December 2004 18:52:22 +0100, Jörn Engel wrote:
> > On Sat, 18 December 2004 17:32:35 +0000, Gareth Bult (Encryptec) wrote:
> > >
> > > There's a public health warning attached to this code ..
> > >
> > > I've not cleaned it up and I've not added any comments ..
> >
> > I'll wear protective gloves then. Thanks!
>
> Not a pretty. Looks like quite a few cleanups from phram.c can be
> applied to this one as well. From a first glance:
> o Coding style (Lindent?)
> o Function length
> o #ifdef MODULE
> o parameters have an insane interface
> o ro-devices. the same can be achieved with chmod.
>
> But you started the work, which is a good thing.
>
> Jörn
>