Re: [2.6 patch] MTD: some cleanups

[Adrian Bunk <bunk@stusta.de>]

On Tue, Nov 16, 2004 at 06:26:07PM +0000, David Woodhouse wrote:
> On Fri, 2004-11-12 at 14:53 +0100, Adrian Bunk wrote:
> > The patch below makes the following cleanups for code under drivers/mtd/ :
> > - make some needlessly global code static
> 
> OK.

Thanks.

> > - remove the following unused code:
> >   - function ftl_freepart in drivers/mtd/ftl.c
> 
> It's a bug that we never free these. We should call the function
> occasionally instead of deleting it.

OK.

> >   - functions nettel_eraseconfig and nettel_erasecallback,
> >    struct nettel_erase in drivers/mtd/maps/nettel.c
> 
> The nettel_eraseconfig() function isn't static -- I assume it was called
> from the nettel-specific platform code.

>From some platform code where the merging into the kernel is pending?

> >   - function physmap_set_partitions in drivers/mtd/maps/physmap.c
> 
> Again that's called from elsewhere.

The merging of the code calling it into the kernel is pending?

> dwmw2

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed