From: Adrian Bunk <bunk@stusta.de>
To: Nicolas Pitre <nico@cam.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] 2.6.10-rc2-mm2: MTD_XIP dependencies
Date: Sun, 21 Nov 2004 20:56:17 +0100 [thread overview]
Message-ID: <20041121195617.GB13254@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0411191130190.3732@xanadu.home>
On Fri, Nov 19, 2004 at 11:35:26AM -0500, Nicolas Pitre wrote:
> On Fri, 19 Nov 2004, Adrian Bunk wrote:
>
> >...
> > The Kconfig file should express all dependencies of a driver.
> > If a driver doesn't compile, it should not be selectable - and not
> > #error at compile time.
>
> Absolutely!
Good that we agree. :-)
> So please would you just ask Andrew to apply the following patch and be
> happy? Thank you.
A slightly improved patch is below.
> --- ./drivers/mtd/chips/Kconfig.orig Fri Nov 19 11:25:45 2004
> +++ ./drivers/mtd/chips/Kconfig Fri Nov 19 11:28:08 2004
> @@ -274,8 +274,7 @@
>
> config MTD_XIP
> bool "XIP aware MTD support"
> - depends on !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
> - default y if XIP_KERNEL
> + depends on XIP_KERNEL && !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
> help
> This allows MTD support to work with flash memory which is also
> used for XIP purposes. If you're not sure what this is all about
>
>
> Nicolas
cu
Adrian
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm2-full/drivers/mtd/chips/Kconfig.old 2004-11-18 16:35:40.000000000 +0100
+++ linux-2.6.10-rc2-mm2-full/drivers/mtd/chips/Kconfig 2004-11-21 20:54:43.000000000 +0100
@@ -274,8 +274,8 @@
config MTD_XIP
bool "XIP aware MTD support"
- depends on !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL
- default y if XIP_KERNEL
+ depends on XIP_KERNEL && !SMP && MTD_CFI_INTELEXT && EXPERIMENTAL && (ARCH_SA1100 || ARCH_PXA || BROKEN)
+ default y
help
This allows MTD support to work with flash memory which is also
used for XIP purposes. If you're not sure what this is all about
next prev parent reply other threads:[~2004-11-21 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041118021538.5764d58c.akpm@osdl.org>
2004-11-18 15:41 ` [patch] 2.6.10-rc2-mm2: MTD_XIP dependencies Adrian Bunk
2004-11-18 15:51 ` David Woodhouse
2004-11-18 16:34 ` Nicolas Pitre
2004-11-18 17:02 ` Russell King
2004-11-18 21:32 ` Adrian Bunk
2004-11-18 22:31 ` Nicolas Pitre
2004-11-18 23:25 ` Adrian Bunk
2004-11-19 1:58 ` Nicolas Pitre
2004-11-19 13:35 ` Adrian Bunk
2004-11-19 16:35 ` Nicolas Pitre
2004-11-21 19:56 ` Adrian Bunk [this message]
2004-11-22 0:38 ` Nicolas Pitre
2004-11-22 7:38 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041121195617.GB13254@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox