PATCH to help understanding

[Charles Manning <manningc2@actrix.gen.nz>]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

Hi folks

I propose the following patches to mtd.h to help the understanding of these 
functions.

read_ecc() and write_ecc() use the argument eccbuff, but this is really oob 
data being passed. The oob data might contain ecc info as well as other 
stuff. With the preferred autoplacement model, this will not have ecc info in 
it. Therefore I suggest a rename on this parameter.

suspend() and resume() are surely the functions for erase suspend and erase 
resume (for those NOR devices that provide this). Perhaps I goofed here and 
these are really power control functions (which would seem rather dodgy). If 
these are really power control fns, then where does erase suspend/resume get 
exposed?

-- Charles

[-- Attachment #2: mtd.h.patch --]
[-- Type: text/x-diff, Size: 1400 bytes --]

diff -Naur oldmtd/mtd.h mtd/mtd.h
--- oldmtd/mtd.h	Fri Dec 17 16:11:34 2004
+++ mtd/mtd.h	Fri Dec 17 16:12:57 2004
@@ -102,8 +102,8 @@
 	int (*read) (struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, u_char *buf);
 	int (*write) (struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, const u_char *buf);
 
-	int (*read_ecc) (struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, u_char *buf, u_char *eccbuf, struct nand_oobinfo *oobsel);
-	int (*write_ecc) (struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, const u_char *buf, u_char *eccbuf, struct nand_oobinfo *oobsel);
+	int (*read_ecc) (struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, u_char *buf, u_char *oobbuf, struct nand_oobinfo *oobsel);
+	int (*write_ecc) (struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, const u_char *buf, u_char *oobbuf, struct nand_oobinfo *oobsel);
 
 	int (*read_oob) (struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, u_char *buf);
 	int (*write_oob) (struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, const u_char *buf);
@@ -139,7 +139,7 @@
 	int (*lock) (struct mtd_info *mtd, loff_t ofs, size_t len);
 	int (*unlock) (struct mtd_info *mtd, loff_t ofs, size_t len);
 
-	/* Power Management functions */
+	/* Erase suspend function ???*/
 	int (*suspend) (struct mtd_info *mtd);
 	void (*resume) (struct mtd_info *mtd);