From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.fh-wedel.de ([213.39.232.198] helo=moskovskaya.fh-wedel.de) by canuck.infradead.org with esmtps (Exim 4.42 #1 (Red Hat Linux)) id 1Cfj2j-0005x5-56 for linux-mtd@lists.infradead.org; Sat, 18 Dec 2004 13:11:02 -0500 Date: Sat, 18 Dec 2004 19:11:00 +0100 From: =?iso-8859-1?Q?J=F6rn?= Engel To: "Gareth Bult (Encryptec)" Message-ID: <20041218181100.GD4147@wohnheim.fh-wedel.de> References: <1103152743.15913.33.camel@squizzey.bult.co.uk> <41C0D3AC.3050801@us.ibm.com> <1103158974.15929.37.camel@squizzey.bult.co.uk> <1103201631.25765.7.camel@weaponx.rchland.ibm.com> <1103232128.15927.70.camel@squizzey.bult.co.uk> <41C1FDFF.3020308@us.ibm.com> <1103233669.15929.81.camel@squizzey.bult.co.uk> <20041218161923.GD1083@wohnheim.fh-wedel.de> <1103391155.10788.13.camel@squizzey.bult.co.uk> <20041218175222.GB4147@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20041218175222.GB4147@wohnheim.fh-wedel.de> Cc: Linux MTD Subject: Re: JFFS2 mount time List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 18 December 2004 18:52:22 +0100, Jörn Engel wrote: > On Sat, 18 December 2004 17:32:35 +0000, Gareth Bult (Encryptec) wrote: > > > > There's a public health warning attached to this code .. > > > > I've not cleaned it up and I've not added any comments .. > > I'll wear protective gloves then. Thanks! Not a pretty. Looks like quite a few cleanups from phram.c can be applied to this one as well. From a first glance: o Coding style (Lindent?) o Function length o #ifdef MODULE o parameters have an insane interface o ro-devices. the same can be achieved with chmod. But you started the work, which is a good thing. Jörn -- Public Domain - Free as in Beer General Public - Free as in Speech BSD License - Free as in Enterprise Shared Source - Free as in "Work will make you..."