public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Jonas Holmberg <jonas.holmberg@axis.com>
To: linux-mtd@lists.infradead.org
Subject: Re: Device ID collision in amd_flash.c
Date: Thu, 3 Feb 2005 10:58:42 +0100	[thread overview]
Message-ID: <20050203095842.GA20345@axis.com> (raw)
In-Reply-To: <20050202110715.GH27015@axis.com>

On Wed, Feb 02, 2005 at 12:07:16PM +0100, Jonas Holmberg wrote:
> The (obsolete) AMD NOR-flash driver has an "probe-table-entry" for 
> AM29BDS643D that happens to match AM29DL640G as well, even though they  
> have different block/sector-layouts.
> 
> I think the problem is that AMD is assigning device-IDs of more than 
> 16-bits.  Anyhow, both AM29BDS643D and AM29DL640G supports CFI, so I 
> would like to remove support for them in amd_flash.c (patch below) to 
> avoid problems.
> 
> OK to commit?

Silly me, who cares about obsolete drivers...
Let me rephrase that question: Any objections before I commit on 
friday (tomorrow)?

I still would like to know how bugfixes finds their way into Linux 
2.4. As I understand, the main trunk in CVS is for 2.6 and I can't 
find any 2.4-branch...

Best regards
/Jonas

> 
> /Jonas
> 
> PS. Would this patch ever find it's way into Linux 2.4 or just Linux 
> 2.6?
> 
> 
> 
> RCS file: /home/cvs/mtd/drivers/mtd/chips/amd_flash.c,v
> retrieving revision 1.26
> diff -u -r1.26 amd_flash.c
> --- amd_flash.c 20 Nov 2004 12:49:04 -0000      1.26
> +++ amd_flash.c 2 Feb 2005 11:03:07 -0000
> @@ -67,7 +67,6 @@
>  #define AM29LV160DT    0x22C4
>  #define AM29LV160DB    0x2249
>  #define AM29BDS323D     0x22D1
> -#define AM29BDS643D    0x227E
>  
>  /* Atmel */
>  #define AT49xV16x      0x00C0
> @@ -618,17 +617,6 @@
>                         { .offset = 0x3f0000, .erasesize = 0x02000, .numblocks =  8 },
>                 }
>         }, {
> -               .mfr_id = MANUFACTURER_AMD,
> -               .dev_id = AM29BDS643D,
> -               .name = "AMD AM29BDS643D",
> -               .size = 0x00800000,
> -               .numeraseregions = 3,
> -               .regions = {
> -                       { .offset = 0x000000, .erasesize = 0x10000, .numblocks = 96 },
> -                       { .offset = 0x600000, .erasesize = 0x10000, .numblocks = 31 },
> -                       { .offset = 0x7f0000, .erasesize = 0x02000, .numblocks =  8 },
> -               }
> -       }, {
>                 .mfr_id = MANUFACTURER_ATMEL,
>                 .dev_id = AT49xV16x,
>                 .name = "Atmel AT49xV16x",
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2005-02-03  9:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02 11:07 Device ID collision in amd_flash.c Jonas Holmberg
2005-02-03  9:58 ` Jonas Holmberg [this message]
2005-02-03 10:23   ` David Woodhouse
2005-02-03 10:55     ` Jonas Holmberg
2005-02-03 11:24       ` David Woodhouse
2005-02-03 14:13         ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050203095842.GA20345@axis.com \
    --to=jonas.holmberg@axis.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox