From: Matthew Reimer <mreimer@vpop.net>
To: tglx@linutronix.de
Cc: linux-mtd@lists.infradead.org
Subject: Re: oobavail issues
Date: Thu, 31 Mar 2005 10:29:46 -0800 [thread overview]
Message-ID: <200503311029.46475.mreimer@vpop.net> (raw)
In-Reply-To: <1112296829.4228.75.camel@tglx.tec.linutronix.de>
On Thursday 31 March 2005 11:20 am, Thomas Gleixner wrote:
> On Thu, 2005-03-31 at 09:29 -0800, Matthew Reimer wrote:
> > I'm not sure what is the correct fix--calculate oobavail differently, or
> > to change the loop condition in nand_prepare_oobbuf, or to require
> > nand_oobinfo.oobfree to cover every OOB byte. We just copied from the
> > s3c2410.c, assuming it was correct.
>
> I will fix this. But I still wonder why you hit this problem with JFFS2.
> JFFS2 does not provide a filesystem buffer for oob data, so the memcpy
> in nand_prepare_oobbuf is never invoked.
IIRC it wasn't jffs2 but the MTD_WRITEECC() we were doing to write a kernel to
a partition, which we had to do in preparation for mounting jffs2. Sorry for
the confusion.
Matt
next prev parent reply other threads:[~2005-03-31 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-31 1:18 oobavail issues Joshua Wise
2005-03-31 11:52 ` Thomas Gleixner
2005-03-31 17:29 ` Matthew Reimer
2005-03-31 19:20 ` Thomas Gleixner
2005-03-31 18:29 ` Matthew Reimer [this message]
2005-04-01 8:23 ` Thomas Gleixner
2005-04-01 17:27 ` Matthew Reimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503311029.46475.mreimer@vpop.net \
--to=mreimer@vpop.net \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox