From: Christoph Hellwig <hch@lst.de>
To: dwmw2@infradead.org, gerg@snapgear.com
Cc: linux-mtd@lists.infradead.org
Subject: [PATCH] don't try to set ROOT_DEV from modular mtd drivers
Date: Thu, 31 Mar 2005 21:52:54 +0200 [thread overview]
Message-ID: <20050331195254.GA9189@lst.de> (raw)
Personally I think setting ROOT_DEV from drivers is a really bad idea
(and these two are the only two drivers actually doing it), but at least
let's do it only for the builtin case so we can kill the ROOT_DEV
export.
--- 1.8/drivers/mtd/maps/nettel.c 2005-01-05 18:17:45 +01:00
+++ edited/drivers/mtd/maps/nettel.c 2005-03-31 21:55:47 +02:00
@@ -415,7 +415,7 @@
intel_mtd->owner = THIS_MODULE;
-#ifndef CONFIG_BLK_DEV_INITRD
+#if !defined(MODULE) && !defined(CONFIG_BLK_DEV_INITRD)
ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 1);
#endif
--- 1.9/drivers/mtd/maps/uclinux.c 2005-01-05 19:08:36 +01:00
+++ edited/drivers/mtd/maps/uclinux.c 2005-03-31 21:55:38 +02:00
@@ -94,7 +94,9 @@
printk("uclinux[mtd]: set %s to be root filesystem\n",
uclinux_romfs[0].name);
+#ifndef MODULE
ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 0);
+#endif
put_mtd_device(mtd);
return(0);
reply other threads:[~2005-03-31 19:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331195254.GA9189@lst.de \
--to=hch@lst.de \
--cc=dwmw2@infradead.org \
--cc=gerg@snapgear.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox