public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] don't try to set ROOT_DEV from modular mtd drivers
@ 2005-03-31 19:52 Christoph Hellwig
  0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2005-03-31 19:52 UTC (permalink / raw)
  To: dwmw2, gerg; +Cc: linux-mtd

Personally I think setting ROOT_DEV from drivers is a really bad idea
(and these two are the only two drivers actually doing it), but at least
let's do it only for the builtin case so we can kill the ROOT_DEV
export.


--- 1.8/drivers/mtd/maps/nettel.c	2005-01-05 18:17:45 +01:00
+++ edited/drivers/mtd/maps/nettel.c	2005-03-31 21:55:47 +02:00
@@ -415,7 +415,7 @@
 
 	intel_mtd->owner = THIS_MODULE;
 
-#ifndef CONFIG_BLK_DEV_INITRD
+#if !defined(MODULE) && !defined(CONFIG_BLK_DEV_INITRD)
 	ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 1);
 #endif
 
--- 1.9/drivers/mtd/maps/uclinux.c	2005-01-05 19:08:36 +01:00
+++ edited/drivers/mtd/maps/uclinux.c	2005-03-31 21:55:38 +02:00
@@ -94,7 +94,9 @@
 
 	printk("uclinux[mtd]: set %s to be root filesystem\n",
 	     	uclinux_romfs[0].name);
+#ifndef MODULE
 	ROOT_DEV = MKDEV(MTD_BLOCK_MAJOR, 0);
+#endif
 	put_mtd_device(mtd);
 
 	return(0);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-03-31 19:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-31 19:52 [PATCH] don't try to set ROOT_DEV from modular mtd drivers Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox