From: Christoph Hellwig <hch@infradead.org>
To: "Artem B. Bityuckiy" <dedekind@infradead.org>
Cc: dwmw2@lists.infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATC] small VFS change for JFFS2
Date: Mon, 18 Apr 2005 11:53:01 +0100 [thread overview]
Message-ID: <20050418105301.GA21878@infradead.org> (raw)
In-Reply-To: <1113814730.31595.6.camel@sauron.oktetlabs.ru>
On Mon, Apr 18, 2005 at 12:58:50PM +0400, Artem B. Bityuckiy wrote:
> On Mon, 2005-04-18 at 09:51 +0100, Christoph Hellwig wrote:
> > No, exporting locks is a really bad idea. Please try to find a better
> > method to fix your problem that doesn't export random kernel symbols.
> >
> In general it must be true. But this specific case I believe is
> reasonable enough to export the mutext (as an exception).
Umm, no. It's absolutely not a good reason. What jffs2 is doing right
now is to poke into VFS internals it shouldn't, and exporting more internals
to prevent it from doing so isn't making the situation any better.
The VFS already has a method for freeing an struct inode pointer, and that
is ->destroy_inode. You're probably better off updating your GC state from
that place.
next prev parent reply other threads:[~2005-04-18 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 8:47 [PATC] small VFS change for JFFS2 Artem B. Bityuckiy
2005-04-18 8:51 ` Christoph Hellwig
2005-04-18 8:58 ` Artem B. Bityuckiy
2005-04-18 10:53 ` Christoph Hellwig [this message]
2005-04-18 11:46 ` Artem B. Bityuckiy
2005-04-18 11:52 ` Christoph Hellwig
2005-04-18 12:31 ` Artem B. Bityuckiy
2005-04-18 12:46 ` David Woodhouse
2005-04-18 12:46 ` Christoph Hellwig
2005-04-18 12:56 ` Artem B. Bityuckiy
2005-04-18 13:08 ` David Woodhouse
2005-04-18 13:38 ` ntfs ->iput use - was: " Anton Altaparmakov
2005-04-18 13:16 ` David Woodhouse
2005-04-18 14:07 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050418105301.GA21878@infradead.org \
--to=hch@infradead.org \
--cc=dedekind@infradead.org \
--cc=dwmw2@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox