From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: ?? ???? <zhao_fusheng@hotmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: A problem in JFFS2 code about ECC'd NOR flash
Date: Wed, 20 Jul 2005 13:30:49 +0200 [thread overview]
Message-ID: <20050720113049.GD3890@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <BAY17-F167D2FBC2A9CD84727C551E8D70@phx.gbl>
On Wed, 20 July 2005 16:28:09 +0800, ?? ???? wrote:
>
> For ECC'd NOR flash, the clean marker is written by
> jffs2_flash_direct_writev() in jffs2_mark_erased_block().
> Then the first 16 bytes of first page is filled with
> clean marker. But wbuf know nothing about this 16 bytes.
> So subsequent jffs2_flash_writev() will have problem. In
> particular jffs2_flash_writev() will write the first page
> for the second time.
> Am I right? Or can this be confirmed by the JFFS2 developer?
This has been answered in irc already, but for the record...
ECC NOR requires writes in aligned multiples of 8 bytes. The wbuf
size is 8 bytes only. 16 bytes, if written through the wbuf, would be
written directly to flash and leave the wbuf empty. Writing them
directly, without wbuf, yields the same result, so current code is
safe.
Jörn
--
Audacity augments courage; hesitation, fear.
-- Publilius Syrus
prev parent reply other threads:[~2005-07-20 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 8:28 A problem in JFFS2 code about ECC'd NOR flash 赵 豆豆
2005-07-20 11:30 ` Jörn Engel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050720113049.GD3890@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
--cc=zhao_fusheng@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox