From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: zhao forrest <zhao_fusheng@hotmail.com>
Cc: dedekind@yandex.ru, tglx@linutronix.de, linux-mtd@lists.infradead.org
Subject: Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block
Date: Mon, 25 Jul 2005 11:20:12 +0200 [thread overview]
Message-ID: <20050725092012.GC10616@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <BAY17-F15C6182BFC9EEA8E5AD337E8CA0@phx.gbl>
On Mon, 25 July 2005 17:10:22 +0800, zhao forrest wrote:
> + node = (struct jffs2_unknown_node *)&buf[current_oob + c->fsdata_pos];
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This part of the patch bugs me a little, even though it's not your
fault. buf should be of type void*, not char* or unsigned char*.
After that conversion, most casts in this function should go away.
Forrest, if you get bored easily, this would be a nice change.
Rest of the patch looks fine, as far as I'm concerned. Thanks.
Jörn
--
When you close your hand, you own nothing. When you open it up, you
own the whole world.
-- Li Mu Bai in Tiger & Dragon
next prev parent reply other threads:[~2005-07-25 9:20 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BAY17-F15C6182BFC9EEA8E5AD337E8CA0@phx.gbl>
2005-07-25 9:14 ` [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block Jörn Engel
2005-07-25 9:20 ` Jörn Engel [this message]
2005-07-21 7:22 赵 豆豆
2005-07-22 11:02 ` Artem B. Bityuckiy
2005-07-22 11:59 ` Jörn Engel
2005-07-22 12:12 ` Artem B. Bityuckiy
2005-07-22 12:27 ` Jörn Engel
2005-07-26 7:36 ` Ferenc Havasi
2005-07-26 7:44 ` Jörn Engel
2005-07-26 7:57 ` Ferenc Havasi
2005-07-26 8:29 ` Steven Scholz
2005-07-26 9:36 ` Jörn Engel
2005-07-26 10:03 ` Ferenc Havasi
2005-07-26 10:12 ` Artem B. Bityuckiy
2005-07-26 10:51 ` Steven Scholz
2005-07-26 11:13 ` Jörn Engel
2005-07-26 11:14 ` Steven Scholz
2005-07-26 12:37 ` Ferenc Havasi
2005-07-26 9:32 ` Jörn Engel
2005-07-26 10:03 ` Jörn Engel
2005-07-27 22:08 ` David Woodhouse
2005-07-28 9:01 ` Jörn Engel
2005-08-01 9:50 ` Havasi Ferenc
2005-08-01 9:56 ` Jörn Engel
2005-08-01 10:07 ` Havasi Ferenc
2005-08-01 10:43 ` Jörn Engel
2005-08-01 14:02 ` Ferenc Havasi
2005-08-01 14:18 ` Jörn Engel
2005-08-11 15:03 ` Ferenc Havasi
2005-08-11 15:47 ` Artem B. Bityuckiy
2005-08-11 16:59 ` Ferenc Havasi
2005-08-11 16:06 ` Artem B. Bityuckiy
2005-08-15 11:24 ` Ferenc Havasi
2005-08-15 12:23 ` Artem B. Bityuckiy
2005-08-15 17:10 ` Ferenc Havasi
2005-08-16 13:19 ` Artem B. Bityuckiy
2005-08-11 17:24 ` Jörn Engel
2005-08-15 9:48 ` Jörn Engel
2005-08-15 10:20 ` Artem B. Bityuckiy
2005-08-15 11:42 ` Ferenc Havasi
2005-08-15 11:56 ` Jörn Engel
2005-08-15 11:07 ` Artem B. Bityuckiy
2005-08-15 11:48 ` Ferenc Havasi
2005-08-15 11:59 ` Jörn Engel
2005-08-15 12:28 ` Ferenc Havasi
2005-08-15 12:38 ` Artem B. Bityuckiy
2005-08-15 12:52 ` Jörn Engel
2005-08-15 13:34 ` Ferenc Havasi
2005-08-15 13:42 ` Artem B. Bityuckiy
2005-08-15 13:48 ` Jörn Engel
2005-08-15 14:00 ` Artem B. Bityuckiy
2005-08-15 14:05 ` Jörn Engel
2005-08-15 14:19 ` Artem B. Bityuckiy
2005-08-15 14:32 ` Jörn Engel
2005-08-15 15:22 ` Artem B. Bityuckiy
2005-08-16 7:16 ` Artem B. Bityuckiy
2005-08-16 7:25 ` Artem B. Bityuckiy
2005-08-16 9:47 ` Jörn Engel
2005-08-16 9:56 ` Artem B. Bityuckiy
2005-08-15 13:43 ` Jörn Engel
2005-08-15 13:46 ` Artem B. Bityuckiy
2005-08-16 11:34 ` Artem B. Bityuckiy
2005-08-15 13:27 ` Ferenc Havasi
2005-08-15 13:40 ` Artem B. Bityuckiy
2005-08-15 13:45 ` Jörn Engel
2005-08-15 13:50 ` Artem B. Bityuckiy
2005-08-15 12:35 ` Artem B. Bityuckiy
2005-08-15 13:22 ` Ferenc Havasi
2005-08-15 13:38 ` Artem B. Bityuckiy
2005-08-15 13:51 ` Jörn Engel
2005-08-15 14:01 ` Artem B. Bityuckiy
2005-08-15 11:53 ` Jörn Engel
2005-08-15 12:46 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050725092012.GC10616@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=dedekind@yandex.ru \
--cc=linux-mtd@lists.infradead.org \
--cc=tglx@linutronix.de \
--cc=zhao_fusheng@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox