Re: mtd/include/linux jffs2.h,1.35,1.36

Re: mtd/include/linux jffs2.h,1.35,1.36

[Jörn Engel]

On Tue, 26 July 2005 14:19:39 +0100, havasi@infradead.org wrote:
> 
> Update of /home/cvs/mtd/include/linux
> In directory phoenix.infradead.org:/tmp/cvs-serv18673
> 
> Modified Files:
> 	jffs2.h 
> Log Message:
> [jffs2] removing compressor lzo and lzari
> 
> Index: jffs2.h
> ===================================================================
> RCS file: /home/cvs/mtd/include/linux/jffs2.h,v
> retrieving revision 1.35
> retrieving revision 1.36
> diff -u -r1.35 -r1.36
> --- jffs2.h	24 Jul 2005 15:15:51 -0000	1.35
> +++ jffs2.h	26 Jul 2005 13:19:36 -0000	1.36
> @@ -43,8 +43,6 @@
>  #define JFFS2_COMPR_COPY	0x04
>  #define JFFS2_COMPR_DYNRUBIN	0x05
>  #define JFFS2_COMPR_ZLIB	0x06
> -#define JFFS2_COMPR_LZO         0x07
> -#define JFFS2_COMPR_LZARI       0x08
>  /* Compatibility flags. */
>  #define JFFS2_COMPAT_MASK 0xc000      /* What do to if an unknown nodetype is found */
>  #define JFFS2_NODE_ACCURATE 0x2000

This patch could cause problems.  We have to make sure 0x07 and 0x08
are never handed out for new compressors, one way or another.

Ferenc, can you add a comment that those numbers are reserved or
obsoleted?

Jörn

-- 
Optimizations always bust things, because all optimizations are, in
the long haul, a form of cheating, and cheaters eventually get caught.
-- Larry Wall 

Re: mtd/include/linux jffs2.h,1.35,1.36

[Ferenc Havasi]

Jörn Engel wrote:

>>-#define JFFS2_COMPR_LZO         0x07
>>-#define JFFS2_COMPR_LZARI       0x08
>> /* Compatibility flags. */
>> #define JFFS2_COMPAT_MASK 0xc000      /* What do to if an unknown nodetype is found */
>> #define JFFS2_NODE_ACCURATE 0x2000
>>    
>>
>
>This patch could cause problems.  We have to make sure 0x07 and 0x08
>are never handed out for new compressors, one way or another.
>
>Ferenc, can you add a comment that those numbers are reserved or
>obsoleted?
>  
>
Compressor lzo and lzari were never used really, I think nobody has
JFFS2 image with blocks compressed by them.

But if you think I can add a comment to make absolutely sure.

Ferenc

Re: mtd/include/linux jffs2.h,1.35,1.36

[Jörn Engel]

On Tue, 26 July 2005 16:21:25 +0200, Ferenc Havasi wrote:
>
> Compressor lzo and lzari were never used really, I think nobody has
> JFFS2 image with blocks compressed by them.
> 
> But if you think I can add a comment to make absolutely sure.

Hmm, ok.  You're right.

For rubin, we want to keep the numbers reserved, but those two are
fine.

Jörn

-- 
It's not whether you win or lose, it's how you place the blame.
-- unknown