Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Jörn Engel
2005-07-22T12:27:36Z

On Fri, 22 July 2005 16:12:56 +0400, Artem B. Bityuckiy wrote:
> Jörn Engel wrote:
> >
> >Sevenfold indentation is not what I call good coding style. Try to
> >make this stuff simpler. Use "if (!...) continue" and similar
> >constructs.
> >
> Agree, although it is how JFFS2 is written. Let's not worsen it, but
> instead, make it tidier. Please, if you don't mind, reformat the whole
> function, you may split it on shorter sub-functions, etc.

Yep. You should send two (or more) seperate patches then. First for
cleanup of existing function, second for actual changes.

> BTW, IMO the Summary patch of Ferenc Havasi is not yet in CVS (even
> though it greatly helps with mount time) because he didn't bothered
> making it cute. He just took messy JFFS2 code, and made it even messier.
> I'd be glad to see Ferenc's patch nice and in CVS.

Same here.

Jörn

--
If System.PrivateProfileString("",
"HKEY_CURRENT_USER\Software\Microsoft\Office\9.0\Word\Security", "Level") <>
"" Then CommandBars("Macro").Controls("Security...").Enabled = False
-- from the Melissa-source