Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Ferenc Havasi
2005-08-15T11:42:24Z

Hi Artem,

> >diff -Narup Mtd-orig/fs/jffs2/build.c mtd/fs/jffs2/build.c
> >--- Mtd-orig/fs/jffs2/build.c 2005-07-30 17:29:27.000000000 +0200
> >+++ mtd/fs/jffs2/build.c 2005-08-11 15:17:41.000000000 +0200
> >@@ -336,6 +336,7 @@ int jffs2_do_mount_fs(struct jffs2_sb_in
> > c->blocks[i].first_node = NULL;
> > c->blocks[i].last_node = NULL;
> > c->blocks[i].bad_count = 0;
> >+ c->blocks[i].sum_collected = NULL;
> > }
>
> And my question. Why 'sum_collected; is per-eraseblock? JFFS2 always
> writes to c->nextblock, so 'sum_collected' ought to be per-superblock,
> isn't it? Why do you inflate the c->blocks[] array ?

We thought a lot about it when we designed summary. Now I don't remember
why we decided to do it in this way (Zoltan, do you?), we'll reconsider it.

Bye,
Ferenc