Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Artem B. Bityuckiy
2005-08-15T12:39:28Z

Ferenc Havasi wrote:
> I only say that for a user the size of the virtual erase block may not
> be evident. They know about the real erase block size. Maybe we should
> write a tool for calculating it.
Why not to just copy the algorithm from JFFS2 (it is in
jffs2_do_fill_super())?

>
> It is not too relevant problem without summary. For example if the erase
> block size is 32K, and the virtual is 64K, and you generates JFFS2
> image for 32K it will work (maybe with some warning but will work). If
> you generates summary for that image for 32K and use it on 64K virtual
> erase block size that will not work.
I think, this is better if you solve this inconsistency in general.

And by the way, I don't understand, why do you need sumtool and
sumtool2? Is sumtool3 coming ?

Why not to merge sumtoolX with mkfs.jffs2 and add more options?

--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.