Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Artem B. Bityuckiy
2005-07-22T12:13:38Z

Jörn Engel wrote:
>
> Sevenfold indentation is not what I call good coding style. Try to
> make this stuff simpler. Use "if (!...) continue" and similar
> constructs.
>
Agree, although it is how JFFS2 is written. Let's not worsen it, but
instead, make it tidier. Please, if you don't mind, reformat the whole
function, you may split it on shorter sub-functions, etc.

BTW, IMO the Summary patch of Ferenc Havasi is not yet in CVS (even
though it greatly helps with mount time) because he didn't bothered
making it cute. He just took messy JFFS2 code, and made it even messier.
I'd be glad to see Ferenc's patch nice and in CVS.

--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.