Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Jörn Engel
2005-07-26T07:44:44Z

On Tue, 26 July 2005 09:36:54 +0200, Ferenc Havasi wrote:
> Artem B. Bityuckiy wrote:
> >BTW, IMO the Summary patch of Ferenc Havasi is not yet in CVS (even
> >though it greatly helps with mount time) because he didn't bothered
> >making it cute. He just took messy JFFS2 code, and made it even messier.
> >I'd be glad to see Ferenc's patch nice and in CVS.
>
> We also would be happy if it summary patch would be the part of the
> official JFFS2 (at least the erase block summary).
>
> If I remember well David (dwmw2) said that it should be the part of
> JFFS3 only, because he would like to see only bugfixes in JFFS2. He did
> not mentioned that the reason is that it is messy.

All of which appeared to make sense back then. By now, I guess,
most people stopped caring about jffs3. The successor of jffs2 should
no longer be log-structured. It's just that noone cared enough to
remove jffs3 from cvs yet.

> If it is true we will
> clean it (or partially rewrite if necessery) just please say some words
> about exactly why and where it is messy.

Can you post a patch or a URL to it?

Jörn

--
Fools ignore complexity. Pragmatists suffer it.
Some can avoid it. Geniuses remove it.
-- Perlis's Programming Proverb #58, SIGPLAN Notices, Sept. 1982