Re: [PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Artem B. Bityuckiy
2005-07-26T10:14:43Z

Ferenc Havasi wrote:
>
> I agree. It would be technically difficult to implement and would make
> the first mount time very-very long.
>

Hi Ferenc,

I have no time to look at your patch right now, but I recall there was
many things like this:

#ifdef SUMMARY
Large block of code. Code is not tidier then the original JFFS2's code.
If you are in scan.c, you wrote the code using scan.c's style...
#endif

In scan.c for example.

Also I saw large blocks of copy-pasted messy JFFS2 code which is
slightly changed, and is embraced by #ifdefs. That's not neat.

I'll review your patch later and will be more specific.

--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.