Re: PATCH: allow JFFS2 to write to really small disks

["Jörn Engel" <joern@wohnheim.fh-wedel.de>]

On Thu, 1 September 2005 13:12:56 +0200, Øyvind Harboe wrote:
> 
> > > 	/* When do we let the GC thread run in the background */
> > >  
> > > 	c->resv_blocks_gctrigger = c->resv_blocks_write + 1;
> > 
> > Minor stuff: You indentation is broken.
> 
> Will fix of course. What emacs mode should I use for indentation? :-)

No idea, I use vim.  Try to mimic existing code, use scripts/Lindent
or read Documentation/CodingStyle.

> > If you changed the patch to add a mount option for the WORM case and
> > check for the mount option instead, this might go in.  Looks like it
> > could be useful.
> 
> I prefer it the way it is now. There are less options to read up on and
> document.
> 
> W.r.t. documentation it would possibly call for a footnote that the
> JFFS2 disk will only support read/write many times if it is large
> enough. If it is too small, it only supports Write Once Read Many. 
> 
> What do you think?

I think that most users don't want JFFS2 to run in WORM mode.  And for
those users, failing on every write is actually better.  They notice
the problem right away, not just after a while.

People that want WORM mode are the minority and therefore should be
the ones that are inconvenienced.

Jörn

-- 
The only real mistake is the one from which we learn nothing.
-- John Powell