Re: [PATCH]Add JFFS2 eraseblock header support

["Jörn Engel" <joern@wohnheim.fh-wedel.de>]

On Tue, 20 September 2005 15:56:04 +0400, Artem B. Bityutskiy wrote:
> On Tue, 2005-09-20 at 13:36 +0200, Jörn Engel wrote:
> > > 
> > > If old binary mounts new image, it starts writing its cleanmarkers, use
> > > 1:N mapping etc. A "mixed" image appears. Afterwords, if this mixed
> > > image is being mounted on new JFFS2 binary, what poor Zhao is supposed
> > > to do? There will be too much ugliness in the code to handle that.
> > 
> > Please don't mix those two problems.  1:1 mapping has been dealt with.
> > If you don't like how it has been dealt with, complain in the context
> > of 1:1 mapping.
> 
> Please, remember the original goal. It is new wear-levelling. This patch
> may be considered as something independent, but it is not optimal. If we
> follow this way, Zhao must:
> 
> 1. Write code which understands both cleanmarkers and EB headers.
> 2. Test that old images are actually work well on new JFFS2.
> 3. Implement 1:1. Remove cleanmarkers support as they are not needed
> anymore.

Not quite.  He must:
1. Assume 1:1 mapping.  If people are not, that's a completely
   seperate problem.
2. Write robust code that does not depend on EBH.  If the header is
   missing, it should just create a new one and initialize its members
   as best it can - e.g. taking the average erase count.
3. Not emit clean markers anymore - they are not needed.

Going back to your list:

> 1. Write code which understands both cleanmarkers and EB headers.

Big deal.  Cleanmarker doesn't really matter, absence of EBH does.

> 2. Test that old images are actually work well on new JFFS2.

Sure!

> 3. Implement 1:1. Remove cleanmarkers support as they are not needed
> anymore.

Nope, why do you keep bringing it up?  1:1 is finished.  History.
Dealt with.  Old coffee.  Not a problem anymore.  Capisci?

Jörn

-- 
You ain't got no problem, Jules. I'm on the motherfucker. Go back in
there, chill them niggers out and wait for the Wolf, who should be
coming directly.
-- Marsellus Wallace