[PATCH] [Trivial] Make physmap messages more user friendly

[PATCH] [Trivial] Make physmap messages more user friendly

[Deepak Saxena]

Can I commit the following to CVS? It makes the message a bit more
readalbe (and obvious that it is in hex) and tells the user if 
the probe failed.

Signed-off-by: Deepak Saxena <dsaxena@plexity.net>

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -50,11 +50,12 @@ static int __init init_physmap(void)
 	static const char *rom_probe_types[] = { "cfi_probe", "jedec_probe", "map_rom", NULL };
 	const char **type;
 
-       	printk(KERN_NOTICE "physmap flash device: %lx at %lx\n", physmap_map.size, physmap_map.phys);
+       	printk(KERN_NOTICE "MTD physmap flash device: %#010lx @ %#010lx\n", 
+			physmap_map.size, physmap_map.phys);
 	physmap_map.virt = ioremap(physmap_map.phys, physmap_map.size);
 
 	if (!physmap_map.virt) {
-		printk("Failed to ioremap\n");
+		printk("MTD physmap: Failed to ioremap\n");
 		return -EIO;
 	}
 
@@ -90,6 +91,8 @@ static int __init init_physmap(void)
 		add_mtd_device(mymtd);
 
 		return 0;
+	} else {
+		printk("MTD physmap: failed to probe flash\n");
 	}
 
 	iounmap(physmap_map.virt);

-- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net

Even a stopped clock gives the right time twice a day.

Re: [PATCH] [Trivial] Make physmap messages more user friendly

[Jörn Engel]

On Thu, 13 October 2005 18:07:26 -0700, Deepak Saxena wrote:
> 
> Can I commit the following to CVS? It makes the message a bit more
> readalbe (and obvious that it is in hex) and tells the user if 
> the probe failed.

I'd like to wait until tglx considers cvs stable enough for a mainline
merge.  Thomas, besides the general lack of time, are there any major
blockers left?

> Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
> 
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -50,11 +50,12 @@ static int __init init_physmap(void)
>  	static const char *rom_probe_types[] = { "cfi_probe", "jedec_probe", "map_rom", NULL };
>  	const char **type;
>  
> -       	printk(KERN_NOTICE "physmap flash device: %lx at %lx\n", physmap_map.size, physmap_map.phys);
> +       	printk(KERN_NOTICE "MTD physmap flash device: %#010lx @ %#010lx\n", 
> +			physmap_map.size, physmap_map.phys);
>  	physmap_map.virt = ioremap(physmap_map.phys, physmap_map.size);
>  
>  	if (!physmap_map.virt) {
> -		printk("Failed to ioremap\n");
> +		printk("MTD physmap: Failed to ioremap\n");
>  		return -EIO;
>  	}
>  
> @@ -90,6 +91,8 @@ static int __init init_physmap(void)
>  		add_mtd_device(mymtd);
>  
>  		return 0;
> +	} else {
> +		printk("MTD physmap: failed to probe flash\n");
                       ^
All other messages were KERN_NOTICE.

>  	}
>  
>  	iounmap(physmap_map.virt);
> 

Jörn

-- 
Mundie uses a textbook tactic of manipulation: start with some
reasonable talk, and lead the audience to an unreasonable conclusion.
-- Bruce Perens

Re: [PATCH] [Trivial] Make physmap messages more user friendly

[Thomas Gleixner]

On Wed, 2005-10-19 at 01:34 +0200, Jörn Engel wrote:
> On Thu, 13 October 2005 18:07:26 -0700, Deepak Saxena wrote:
> > 
> > Can I commit the following to CVS? It makes the message a bit more
> > readalbe (and obvious that it is in hex) and tells the user if 
> > the probe failed.
> 
> I'd like to wait until tglx considers cvs stable enough for a mainline
> merge.  Thomas, besides the general lack of time, are there any major
> blockers left?

Not that I'm aware of. I put it on the agenda for the weekend.

tglx