From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c
Date: Tue, 8 Nov 2005 11:59:24 +0100 [thread overview]
Message-ID: <20051108105923.GA31446@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20051105162712.921102000@b551138y.boeblingen.de.ibm.com>
On Sat, 5 November 2005 17:26:56 +0100, Arnd Bergmann wrote:
>
> The MTD ioctls are all specific to mtdchar.c, so the
> compat code for them should be there as well.
>
> Also, some of the ioctl commands used in that driver
> were previously not marked as compatible.
>
> The conversion handlers could be further simplified
> by not using compat_alloc_user_space any more.
>
> CC: dwmw2@infradead.org
> CC: linux-mtd@lists.infradead.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jörn Engel <joern@wh.fh-wedel.de>
Moving crap over to mtdchar.c is a good thing. Complete removal of
mtdchar.c might be even better, but at least the crap is relatively
self-contained now.
Jörn
--
When in doubt, punt. When somebody actually complains, go back and fix it...
The 90% solution is a good thing.
-- Rob Landley
next prev parent reply other threads:[~2005-11-08 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 16:26 [PATCH 00/25] reduce code in fs/compat_ioctl.c Arnd Bergmann
2005-11-05 16:26 ` [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c Arnd Bergmann
2005-11-08 10:59 ` Jörn Engel [this message]
2005-11-08 18:10 ` Eric W. Biederman
2005-11-08 18:33 ` Jörn Engel
2005-11-08 18:45 ` Josh Boyer
2005-11-08 18:57 ` Thomas Gleixner
2005-11-08 22:21 ` Jörn Engel
2005-11-09 0:04 ` Thomas Gleixner
2005-11-08 19:03 ` David Woodhouse
2005-11-09 15:37 ` Eric W. Biederman
2005-11-09 15:48 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051108105923.GA31446@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox