Re: [PATCH 1/2] --cvs-exclude for mkfs.jffs2

[Wolfgang Denk <wd@denx.de>]

In message <v0sltfeb45.fsf@marajade.sandelman.ca> you wrote:
>
>     Wolfgang> You use CVS, others use GIT, or Subversion, or ClearCase, or
>     Wolfgang> Monotone, or darcs, or ... - it would not be really practical
>     Wolfgang> to add special rules for everybody's favorite tool.
> 
>   It would very much be practical to do this.
>   I'd rather have a more general --exclude.

Now *this*  is  something  completely  different.  If  you  implement
generic  exclude feature, like the "--exclude=PATTERN" optioon in GNU
tar, than this would be really useful.

Just hard-coding a specific directory name  is  nothing  else  but  a
quick and dirty hack and should IMHO not be accepted for public code.

>   Of course, you argue for removing equivalent options from rsync and other
> things.  Accept the patch or not. 

Note that "rsync and other things"  do  not  hard-code  any  specific
names.

My vote is clear: this patch should not be accepted as is.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
But it's real. And if it's real it can be affected ... we may not  be
able  to break it, but, I'll bet you credits to Navy Beans we can put
a dent in it.
	-- deSalle, "Catspaw", stardate 3018.2