Re: [PATCH] treat OOB as a single chunk of oobavail bytes

[Charles Manning <manningc2@actrix.gen.nz>]

On Wednesday 30 November 2005 04:02, Vitaly Wool wrote:
> Hi,
>
> the patch below implements treating the OOB data as a chunk of _free_ OOB
> bytes of mtd->oobavail size. This is what was announced several times. This
> patch is a working one (verified with yaffs2 and jffs2), however, it's not
> completely ready to work with 16bit NAND flashes. Anyway, I'd like to ask
> for a permission to commit it to let other people start using it/report the
> problems/etc. etc.
>
> Of course input of any kind is welcome.
>
> Best regards,
>    Vitaly


Bloody Marvelous! This is very good news for the yaffs folk.

My only concern/query is a taste issue:
Should the read_oob funtion be used to do the available read or should is it 
better to use a different function like read_ecc() using NULL for the data 
argument?

I have enumerated what I believe to be the pros and cons a few times, and I 
prefer using read_ecc with NULL because this is unambiguous.

However this is a taste issue and to me having a solution is better than 
having an argument!

-- CHarles