public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] no longer mark MTD_OBSOLETE_CHIPS as BROKEN and remove broken MTD_OBSOLETE_CHIPS drivers
Date: Tue, 13 Dec 2005 00:06:06 -0000	[thread overview]
Message-ID: <20051213000539.GQ23349@stusta.de> (raw)
In-Reply-To: <1134380295.10234.62.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 2072 bytes --]

On Mon, Dec 12, 2005 at 10:38:15AM +0100, David Woodhouse wrote:
> On Sun, 2005-12-11 at 20:31 +0100, Adrian Bunk wrote:
> > Either the depency of MTD_OBSOLETE_CHIPS on BROKEN is correct (in
> > which case CONFIG_MTD_OBSOLETE_CHIPS=y wouldn't bring you anything),
> > or the dependency on BROKEN is not correct and should be corrected.
> > 
> > David, can you comment on this issue?
> 
> I don't see any justification for MTD_OBSOLETE_CHIPS depending on
> BROKEN. That option covers a few of the obsolete chip drivers which
> people shouldn't be using any more -- and I'm perfectly willing to
> believe that one or two of those don't work any more, but if that's the
> case then those individual drivers ought to be marked BROKEN (or just
> removed). We shouldn't mark MTD_OBSOLETE_CHIPS broken.
>...

Two of them don't even compile any more.

The patch below removes them and all code depending on them and makes 
the remaining one (MTD_SHARP) compilable again.

> dwmw2

cu
Adrian


<--  snip  -->


MTD_OBSOLETE_CHIPS shouldn't be marked as BROKEN.

This patch brings the MTD_SHARP driver back into life and removes the 
non-compiling MTD_AMDSTD and MTD_JEDEC with everything depending on 
them.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

<--  snip  -->

Due to it's size, the patch is attached gzip'ed.

 arch/cris/arch-v10/drivers/Kconfig        |    1 
 arch/cris/arch-v10/drivers/axisflashmap.c |    3 
 arch/cris/arch-v32/drivers/Kconfig        |    1 
 arch/cris/arch-v32/drivers/axisflashmap.c |    3 
 drivers/mtd/chips/Kconfig                 |   22 
 drivers/mtd/chips/Makefile                |    2 
 drivers/mtd/chips/amd_flash.c             | 1403 ----------------------
 drivers/mtd/chips/jedec.c                 |  935 --------------
 drivers/mtd/maps/Kconfig                  |   18 
 drivers/mtd/maps/Makefile                 |    2 
 drivers/mtd/maps/octagon-5066.c           |  248 ---
 drivers/mtd/maps/vmax301.c                |  198 ---
 include/linux/mtd/jedec.h                 |   66 -
 13 files changed, 1 insertion(+), 2901 deletions(-)


[-- Attachment #2: patch-MTD_OBSOLETE_CHIPS.gz --]
[-- Type: application/octet-stream, Size: 19885 bytes --]

  parent reply	other threads:[~2005-12-13  0:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20051211185212.GQ23349@stusta.de>
     [not found] ` <20051211192109.GA22537@flint.arm.linux.org.uk>
2005-12-11 19:31   ` [2.6 patch] defconfig's shouldn't set CONFIG_BROKEN=y Adrian Bunk
     [not found]     ` <1134380295.10234.62.camel@localhost.localdomain>
2005-12-13  0:06       ` Adrian Bunk [this message]
     [not found]     ` <20051211194437.GB22537@flint.arm.linux.org.uk>
2005-12-13  0:10       ` Adrian Bunk
     [not found]         ` <439ECDCC.80707@hogyros.de>
2005-12-13 14:00           ` Adrian Bunk
2005-12-13 17:31             ` Russell King
2005-12-13 18:05               ` [2.6 patch] don't allow users to " Adrian Bunk
2005-12-13 18:28                 ` Geert Uytterhoeven
2005-12-13 18:51                   ` Adrian Bunk
2005-12-13 18:59                   ` Jesper Juhl
2005-12-13 20:01                 ` Russell King
2005-12-13 20:19                   ` Adrian Bunk
2005-12-13 22:01                     ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051213000539.GQ23349@stusta.de \
    --to=bunk@stusta.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox