public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@linuxtv.org>
To: linux-mtd@lists.infradead.org
Subject: Fix mounting jffs2 by mtd name
Date: Wed, 14 Dec 2005 15:25:12 +0100	[thread overview]
Message-ID: <20051214142512.GA10310@linuxtv.org> (raw)

Hi,

Busybox mount insists that mtd: refers to a NFS mount:

# cat /proc/mtd
dev:    size   erasesize  name
mtd0: 02000000 00004000 "foo"
# mount mtd:foo /mnt -t jffs2
mount: mtd: Unknown host
mount: nfsmount failed: Connection refused
mount: Mounting mtd:foo on /mnt failed: Invalid argument

I suggest new syntax:

# mount mtd/foo /mnt -t jffs2

Signed-off-by: Johannes Stezenbach <js@linuxtv.org>

Index: fs/jffs2/super.c
===================================================================
RCS file: /home/cvs/mtd/fs/jffs2/super.c,v
retrieving revision 1.112
diff -u -p -r1.112 super.c
--- fs/jffs2/super.c	24 Nov 2005 16:13:25 -0000	1.112
+++ fs/jffs2/super.c	14 Dec 2005 14:05:58 -0000
@@ -208,7 +208,7 @@ static struct super_block *jffs2_get_sb(
 
 	if (dev_name[0] == 'm' && dev_name[1] == 't' && dev_name[2] == 'd') {
 		/* Probably mounting without the blkdev crap */
-		if (dev_name[3] == ':') {
+		if (dev_name[3] == '/') {
 			struct mtd_info *mtd;
 
 			/* Mount by MTD device name */

             reply	other threads:[~2005-12-14 14:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-14 14:25 Johannes Stezenbach [this message]
2005-12-16 17:24 ` Fix mounting jffs2 by mtd name Johannes Stezenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214142512.GA10310@linuxtv.org \
    --to=js@linuxtv.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox