[PATCH] Fix compilation errors in maps/dc21285.c

[PATCH] Fix compilation errors in maps/dc21285.c

[Martin Michlmayr]

This patch fixes the following compilation errors in maps/dc21285.c.

  CC      drivers/mtd/maps/dc21285.o
drivers/mtd/maps/dc21285.c: In function ‘dc21285_copy_to_32’:
drivers/mtd/maps/dc21285.c:113: error: invalid lvalue in increment
drivers/mtd/maps/dc21285.c: In function ‘dc21285_copy_to_16’:
drivers/mtd/maps/dc21285.c:124: error: invalid lvalue in increment
drivers/mtd/maps/dc21285.c: In function ‘dc21285_copy_to_8’:
drivers/mtd/maps/dc21285.c:134: error: invalid lvalue in increment
make[3]: *** [drivers/mtd/maps/dc21285.o] Error 1

Signed-off-by: Martin Michlmayr <tbm@cyrius.com>

---

 dc21285.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

The patch is against 2.6.15

--- drivers/mtd/maps/dc21285.c~	2006-01-10 19:40:53.000000000 +0000
+++ drivers/mtd/maps/dc21285.c	2006-01-10 19:52:14.000000000 +0000
@@ -110,8 +110,9 @@
 {
 	while (len > 0) {
 		map_word d;
-		d.x[0] = *((uint32_t*)from)++;
+		d.x[0] = *((uint32_t*)from);
 		dc21285_write32(map, d, to);
+		from += 4;
 		to += 4;
 		len -= 4;
 	}
@@ -121,8 +122,9 @@
 {
 	while (len > 0) {
 		map_word d;
-		d.x[0] = *((uint16_t*)from)++;
+		d.x[0] = *((uint16_t*)from);
 		dc21285_write16(map, d, to);
+		from += 2;
 		to += 2;
 		len -= 2;
 	}
@@ -131,8 +133,9 @@
 static void dc21285_copy_to_8(struct map_info *map, unsigned long to, const void *from, ssize_t len)
 {
 	map_word d;
-	d.x[0] = *((uint8_t*)from)++;
+	d.x[0] = *((uint8_t*)from);
 	dc21285_write8(map, d, to);
+	from++;
 	to++;
 	len--;
 }

-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] Fix compilation errors in maps/dc21285.c

[Martin Michlmayr]

* Martin Michlmayr <tbm@cyrius.com> [2006-01-10 21:20]:
> This patch fixes the following compilation errors in maps/dc21285.c.

This is in Linus' git tree now.
-- 
Martin Michlmayr
http://www.cyrius.com/

Re: [PATCH] Fix compilation errors in maps/dc21285.c

[Jörn Engel]

On Sat, 4 February 2006 00:51:11 +0000, Martin Michlmayr wrote:
> 
> * Martin Michlmayr <tbm@cyrius.com> [2006-01-10 21:20]:
> > This patch fixes the following compilation errors in maps/dc21285.c.
> 
> This is in Linus' git tree now.

Thanks Martin!

Jörn

-- 
Fancy algorithms are slow when n is small, and n is usually small.
Fancy algorithms have big constants. Until you know that n is
frequently going to be big, don't get fancy.
-- Rob Pike