* [RFC: 2.6 patch] MTD_NAND_SHARPSL and MTD_NAND_NANDSIM should be tristate's
@ 2006-01-13 11:48 Adrian Bunk
2006-01-13 14:45 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-01-13 11:48 UTC (permalink / raw)
To: dwmw2; +Cc: linux-mtd, LKML
MTD_NAND=m and MTD_NAND_SHARPSL=y or MTD_NAND_NANDSIM=y are illegal
combinations that mustn't be allowed.
This patch fixes this bug by making MTD_NAND_SHARPSL and
MTD_NAND_NANDSIM tristate's.
Additionally, it fixes some whitespace damage at these options.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 31 Dec 2005
--- linux-git/drivers/mtd/nand/Kconfig.old 2005-12-31 12:20:12.000000000 +0100
+++ linux-git/drivers/mtd/nand/Kconfig 2005-12-31 12:21:35.000000000 +0100
@@ -178,17 +178,16 @@
Even if you leave this disabled, you can enable BBT writes at module
load time (assuming you build diskonchip as a module) with the module
parameter "inftl_bbt_write=1".
-
- config MTD_NAND_SHARPSL
- bool "Support for NAND Flash on Sharp SL Series (C7xx + others)"
- depends on MTD_NAND && ARCH_PXA
-
- config MTD_NAND_NANDSIM
- bool "Support for NAND Flash Simulator"
- depends on MTD_NAND && MTD_PARTITIONS
+config MTD_NAND_SHARPSL
+ tristate "Support for NAND Flash on Sharp SL Series (C7xx + others)"
+ depends on MTD_NAND && ARCH_PXA
+
+config MTD_NAND_NANDSIM
+ tristate "Support for NAND Flash Simulator"
+ depends on MTD_NAND && MTD_PARTITIONS
help
The simulator may simulate verious NAND flash chips for the
MTD nand layer.
-
+
endmenu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC: 2.6 patch] MTD_NAND_SHARPSL and MTD_NAND_NANDSIM should be tristate's
2006-01-13 11:48 Adrian Bunk
@ 2006-01-13 14:45 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2006-01-13 14:45 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-mtd, dwmw2, LKML
On Fri, 2006-01-13 at 12:48 +0100, Adrian Bunk wrote:
> MTD_NAND=m and MTD_NAND_SHARPSL=y or MTD_NAND_NANDSIM=y are illegal
> combinations that mustn't be allowed.
>
> This patch fixes this bug by making MTD_NAND_SHARPSL and
> MTD_NAND_NANDSIM tristate's.
>
> Additionally, it fixes some whitespace damage at these options.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
>
> This patch was already sent on:
> - 31 Dec 2005
>
I can ack the MTD_NAND_SHARPSL part of the patch.
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC: 2.6 patch] MTD_NAND_SHARPSL and MTD_NAND_NANDSIM should be tristate's
@ 2006-01-22 17:12 Adrian Bunk
2006-01-22 17:27 ` Artem B. Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-01-22 17:12 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mtd, dwmw2, LKML
MTD_NAND=m and MTD_NAND_SHARPSL=y or MTD_NAND_NANDSIM=y are illegal
combinations that mustn't be allowed.
This patch fixes this bug by making MTD_NAND_SHARPSL and
MTD_NAND_NANDSIM tristate's.
Additionally, it fixes some whitespace damage at these options.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Richard Purdie <rpurdie@rpsys.net>
---
This patch was already sent on:
- 13 Jan 2006
- 31 Dec 2005
--- linux-git/drivers/mtd/nand/Kconfig.old 2005-12-31 12:20:12.000000000 +0100
+++ linux-git/drivers/mtd/nand/Kconfig 2005-12-31 12:21:35.000000000 +0100
@@ -178,17 +178,16 @@
Even if you leave this disabled, you can enable BBT writes at module
load time (assuming you build diskonchip as a module) with the module
parameter "inftl_bbt_write=1".
-
- config MTD_NAND_SHARPSL
- bool "Support for NAND Flash on Sharp SL Series (C7xx + others)"
- depends on MTD_NAND && ARCH_PXA
-
- config MTD_NAND_NANDSIM
- bool "Support for NAND Flash Simulator"
- depends on MTD_NAND && MTD_PARTITIONS
+config MTD_NAND_SHARPSL
+ tristate "Support for NAND Flash on Sharp SL Series (C7xx + others)"
+ depends on MTD_NAND && ARCH_PXA
+
+config MTD_NAND_NANDSIM
+ tristate "Support for NAND Flash Simulator"
+ depends on MTD_NAND && MTD_PARTITIONS
help
The simulator may simulate verious NAND flash chips for the
MTD nand layer.
-
+
endmenu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC: 2.6 patch] MTD_NAND_SHARPSL and MTD_NAND_NANDSIM should be tristate's
2006-01-22 17:12 [RFC: 2.6 patch] MTD_NAND_SHARPSL and MTD_NAND_NANDSIM should be tristate's Adrian Bunk
@ 2006-01-22 17:27 ` Artem B. Bityutskiy
0 siblings, 0 replies; 4+ messages in thread
From: Artem B. Bityutskiy @ 2006-01-22 17:27 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, dwmw2, linux-mtd, LKML
Adrian Bunk wrote:
> - config MTD_NAND_NANDSIM
> - bool "Support for NAND Flash Simulator"
> - depends on MTD_NAND && MTD_PARTITIONS
Oh, thanks, long time supposed to be fixed.
--
Best Regards,
Artem B. Bityutskiy,
St.-Petersburg, Russia.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-01-22 17:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-22 17:12 [RFC: 2.6 patch] MTD_NAND_SHARPSL and MTD_NAND_NANDSIM should be tristate's Adrian Bunk
2006-01-22 17:27 ` Artem B. Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2006-01-13 11:48 Adrian Bunk
2006-01-13 14:45 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox