From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Jesse Off <joff@embeddedARM.com>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH,RFC] ts72xx NAND driver
Date: Thu, 2 Mar 2006 18:32:02 +0100 [thread overview]
Message-ID: <20060302173202.GA28045@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20060302171539.GA30402@xi.wantstofly.org>
On Thu, 2 March 2006 18:15:39 +0100, Lennert Buytenhek wrote:
>
> > > + if (nand_scan (ts7250_mtd, 1)) {
> > > + kfree (ts7250_mtd);
> > ^
> > Non-compliant to kernel coding style.
>
> ACK.
>
> New version attached -- how does this look?
Unchanged wrt. the second irrelevant comment.
Jörn
--
The competent programmer is fully aware of the strictly limited size of
his own skull; therefore he approaches the programming task in full
humility, and among other things he avoids clever tricks like the plague.
-- Edsger W. Dijkstra
next prev parent reply other threads:[~2006-03-02 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 13:12 [PATCH,RFC] ts72xx NAND driver Lennert Buytenhek
2006-03-02 13:54 ` Jörn Engel
2006-03-02 17:15 ` Lennert Buytenhek
2006-03-02 17:32 ` Jörn Engel [this message]
2006-03-02 18:19 ` Lennert Buytenhek
2006-03-03 6:53 ` Artem B. Bityutskiy
2006-03-03 10:49 ` Jörn Engel
2006-03-03 12:56 ` Josh Boyer
2006-03-03 13:10 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302173202.GA28045@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=buytenh@wantstofly.org \
--cc=joff@embeddedARM.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox