Re: [PATCH/RFC] Add Amstrad Delta NAND support.

Jörn Engel
2006-04-25T13:48:38Z

On Tue, 25 April 2006 14:43:12 +0100, David Woodhouse wrote:
>
> > +/*
> > + * These 3 functions are basically identical to the ones in nand_base.c, but
> > + * we have to call our read_byte/write_byte functions instead of readb/writeb
> > + * directly. I submitted a patch to MTD to move this to nand_base.c, but it
> > + * was deemed too intrusive.
> > + */
>
> Thomas' decision, I assume? I think he's right -- this way it can be
> inlined in the loop rather than being a real function call for every
> byte.

We could have a nand_read_byte()/nand_write_byte() pair of macros that
are defined to readb/writeb for the generic case and to
read_byte/write_byte for CONFIG_FIND_SOME_SANE_NAME.

Jörn

--
My second remark is that our intellectual powers are rather geared to
master static relations and that our powers to visualize processes
evolving in time are relatively poorly developed.
-- Edsger W. Dijkstra