From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Linux-MTD Mailing List <linux-mtd@lists.infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Subject: Re: [MTD] Basic NAND driver for AMD/NatSemi CS5535/CS5536 Geode companion chip
Date: Fri, 12 May 2006 00:39:48 +0200 [thread overview]
Message-ID: <20060511223948.GG14232@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <E1FeJBW-0002Du-BX@pentafluge.infradead.org>
On Thu, 11 May 2006 22:59:02 +0100, Linux-MTD Mailing List wrote:
>
> +static int cs553x_device_ready(struct mtd_info *mtd)
> +{
> + struct nand_chip *this = mtd->priv;
> + void __iomem *mmio_base = this->IO_ADDR_R;
> + unsigned char foo = readb(mmio_base + MM_NAND_STS);
> +
> + return (foo & CS_NAND_STS_FLASH_RDY) && !(foo & CS_NAND_CTLR_BUSY);
Foo?
> + /* Initialize structures */
> + memset((char *) new_mtd, 0, sizeof(struct mtd_info));
> + memset((char *) this, 0, sizeof(struct nand_chip));
Why the cast?
> + kfree (new_mtd);
Extra space.
Jörn
--
Invincibility is in oneself, vulnerability is in the opponent.
-- Sun Tzu
next parent reply other threads:[~2006-05-11 22:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1FeJBW-0002Du-BX@pentafluge.infradead.org>
2006-05-11 22:39 ` Jörn Engel [this message]
2006-05-11 23:39 ` [MTD] Basic NAND driver for AMD/NatSemi CS5535/CS5536 Geode companion chip David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060511223948.GG14232@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox