* 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553
[not found] <20060515005637.00b54560.akpm@osdl.org>
@ 2006-05-16 10:25 ` Adrian Bunk
2006-05-16 12:13 ` David Woodhouse
2006-05-16 11:46 ` [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's Adrian Bunk
2006-05-16 12:37 ` [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static Adrian Bunk
2 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-05-16 10:25 UTC (permalink / raw)
To: Andrew Morton, dwmw2; +Cc: linux-mtd, linux-kernel
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc3-mm1:
>...
> git-mtd.patch
>...
> git trees
>...
This patch adds an MTD_NAND_CS553 option without a help text.
Please add at least a small help text.
TIA
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
@ 2006-05-16 12:13 ` David Woodhouse
0 siblings, 0 replies; 6+ messages in thread
From: David Woodhouse @ 2006-05-16 12:13 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-mtd, linux-kernel
On Tue, 2006-05-16 at 12:25 +0200, Adrian Bunk wrote:
> This patch adds an MTD_NAND_CS553 option without a help text.
>
> Please add at least a small help text.
Done; thanks.
config MTD_NAND_CS553X
tristate "NAND support for CS5535/CS5536 (AMD Geode companion chip)"
depends on MTD_NAND && X86_PC && PCI
help
The CS553x companion chips for the AMD Geode processor
include NAND flash controllers with built-in hardware ECC
capabilities; enabling this option will allow you to use
these. The driver will check the MSRs to verify that the
controller is enabled for NAND, and currently requires that
the controller be in MMIO mode.
If you say "m", the module will be called "cs553x_nand.ko".
--
dwmw2
^ permalink raw reply [flat|nested] 6+ messages in thread
* [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's
[not found] <20060515005637.00b54560.akpm@osdl.org>
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
@ 2006-05-16 11:46 ` Adrian Bunk
2006-05-16 12:14 ` David Woodhouse
2006-05-16 12:37 ` [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static Adrian Bunk
2 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-05-16 11:46 UTC (permalink / raw)
To: Andrew Morton, dwmw2; +Cc: linux-mtd, linux-kernel
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc3-mm1:
>...
> git-mtd.patch
>...
> git trees
>...
If we correct the names of the config options, the code might actually
work as intended...
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/mtd/devices/docprobe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.17-rc4-mm1-full/drivers/mtd/devices/docprobe.c.old 2006-05-16 12:58:49.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/drivers/mtd/devices/docprobe.c 2006-05-16 12:59:08.000000000 +0200
@@ -231,21 +231,21 @@
static int docfound;
-#ifdef CONFIG_DOC2000
+#ifdef CONFIG_MTD_DOC2000
extern void DoC2k_init(struct mtd_info *);
#define doc2k_initfunc (&DoC2k_init)
#else
#define doc2k_initfunc NULL
#endif
-#ifdef CONFIG_DOC2001
+#ifdef CONFIG_MTD_DOC2001
extern void DoCMil_init(struct mtd_info *);
#define docmil_initfunc (&DoCMil_init)
#else
#define docmil_initfunc NULL
#endif
-#ifdef CONFIG_DOC2001PLUS
+#ifdef CONFIG_MTD_DOC2001PLUS
extern void DoCMilPlus_init(struct mtd_info *);
#define docmplus_initfunc (&DoCMilPlus_init)
#else
^ permalink raw reply [flat|nested] 6+ messages in thread* [-mm patch] make drivers/mtd/nand/cs553x_nand.c:cs553x_init() static
[not found] <20060515005637.00b54560.akpm@osdl.org>
2006-05-16 10:25 ` 2.6.17-rc4-mm1: no help text for MTD_NAND_CS553 Adrian Bunk
2006-05-16 11:46 ` [-mm patch] drivers/mtd/devices/docprobe.c: correct #if's Adrian Bunk
@ 2006-05-16 12:37 ` Adrian Bunk
2006-05-16 13:04 ` David Woodhouse
2 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-05-16 12:37 UTC (permalink / raw)
To: Andrew Morton, dwmw2; +Cc: linux-mtd, linux-kernel
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-rc3-mm1:
>...
> git-mtd.patch
>...
> git trees
>...
This patch makes the needlessly global cs553x_init() static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.17-rc4-mm1-full/drivers/mtd/nand/cs553x_nand.c.old 2006-05-16 13:02:13.000000000 +0200
+++ linux-2.6.17-rc4-mm1-full/drivers/mtd/nand/cs553x_nand.c 2006-05-16 13:02:24.000000000 +0200
@@ -267,7 +267,7 @@
return err;
}
-int __init cs553x_init(void)
+static int __init cs553x_init(void)
{
int err = -ENXIO;
int i;
^ permalink raw reply [flat|nested] 6+ messages in thread