* Re: [MTD] Avoid 64-bit division in mtdconcat
[not found] <E1FhOEg-0003dX-4R@pentafluge.infradead.org>
@ 2006-05-20 21:11 ` Josh Boyer
2006-05-20 21:19 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2006-05-20 21:11 UTC (permalink / raw)
To: Linux-MTD Mailing List; +Cc: Andrew Morton
On 5/20/06, Linux-MTD Mailing List <linux-mtd@lists.infradead.org> wrote:
> Commit: 6c8b44abc86a3e23dd1a22c0ee187f06bd7c7f5d
> Parent: 5fc3dbc418e01345e25e96b3192a1c46051c3fdc
> Author: Andrew Morton <akpm@osdl.org>
> AuthorDate: Sat May 20 10:17:21 2006 +0100
> Commit: David Woodhouse <dwmw2@infradead.org>
> CommitDate: Sat May 20 10:17:21 2006 +0100
>
> [MTD] Avoid 64-bit division in mtdconcat
>
> WARNING: "__moddi3" [drivers/mtd/mtdconcat.ko] undefined!
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
NAK. asm-ppc/div64.h doesn't exist. Whether we like it or not,
arch/ppc is still valid and this breaks mtdconcat support on lots of
embedded stuff. There might be other architectures too, but only one
is required for this to be broken :).
josh
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [MTD] Avoid 64-bit division in mtdconcat
2006-05-20 21:11 ` [MTD] Avoid 64-bit division in mtdconcat Josh Boyer
@ 2006-05-20 21:19 ` Andrew Morton
2006-05-21 14:32 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2006-05-20 21:19 UTC (permalink / raw)
To: Josh Boyer; +Cc: linux-mtd
"Josh Boyer" <jwboyer@gmail.com> wrote:
>
> On 5/20/06, Linux-MTD Mailing List <linux-mtd@lists.infradead.org> wrote:
> > Commit: 6c8b44abc86a3e23dd1a22c0ee187f06bd7c7f5d
> > Parent: 5fc3dbc418e01345e25e96b3192a1c46051c3fdc
> > Author: Andrew Morton <akpm@osdl.org>
> > AuthorDate: Sat May 20 10:17:21 2006 +0100
> > Commit: David Woodhouse <dwmw2@infradead.org>
> > CommitDate: Sat May 20 10:17:21 2006 +0100
> >
> > [MTD] Avoid 64-bit division in mtdconcat
> >
> > WARNING: "__moddi3" [drivers/mtd/mtdconcat.ko] undefined!
> >
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> NAK. asm-ppc/div64.h doesn't exist.
It must exist. Things like mm/vmscan.c include it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [MTD] Avoid 64-bit division in mtdconcat
2006-05-20 21:19 ` Andrew Morton
@ 2006-05-21 14:32 ` Josh Boyer
2006-05-21 17:04 ` David Woodhouse
0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2006-05-21 14:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mtd
On 5/20/06, Andrew Morton <akpm@osdl.org> wrote:
> "Josh Boyer" <jwboyer@gmail.com> wrote:
> > > [MTD] Avoid 64-bit division in mtdconcat
> > >
> > > WARNING: "__moddi3" [drivers/mtd/mtdconcat.ko] undefined!
> > >
> > > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> >
> > NAK. asm-ppc/div64.h doesn't exist.
>
> It must exist. Things like mm/vmscan.c include it.
Ugh. Of course, you're right. It's obfuscated by having
-Iarch/ppc/include and then having arch/ppc/include/asm a symlink to
include/asm-powerpc.
Sigh.
Sorry for the noise. At least it motivated me to finally setup a
cross compile environment on my new machine ;)
josh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [MTD] Avoid 64-bit division in mtdconcat
2006-05-21 14:32 ` Josh Boyer
@ 2006-05-21 17:04 ` David Woodhouse
2006-05-21 19:03 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2006-05-21 17:04 UTC (permalink / raw)
To: Josh Boyer; +Cc: Andrew Morton, linux-mtd
On Sun, 2006-05-21 at 09:32 -0500, Josh Boyer wrote:
> Sorry for the noise. At least it motivated me to finally setup a
> cross compile environment on my new machine ;)
And to switch your board to arch/powerpc too, I hope?
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [MTD] Avoid 64-bit division in mtdconcat
2006-05-21 17:04 ` David Woodhouse
@ 2006-05-21 19:03 ` Josh Boyer
0 siblings, 0 replies; 5+ messages in thread
From: Josh Boyer @ 2006-05-21 19:03 UTC (permalink / raw)
To: David Woodhouse; +Cc: Andrew Morton, linux-mtd
On 5/21/06, David Woodhouse <dwmw2@infradead.org> wrote:
> On Sun, 2006-05-21 at 09:32 -0500, Josh Boyer wrote:
> > Sorry for the noise. At least it motivated me to finally setup a
> > cross compile environment on my new machine ;)
>
> And to switch your board to arch/powerpc too, I hope?
Eventually, yes. 4xx is currently lagging quite a bit in that area
and there's no clear direction for a dtb yet. More sighs.
josh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-05-21 19:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1FhOEg-0003dX-4R@pentafluge.infradead.org>
2006-05-20 21:11 ` [MTD] Avoid 64-bit division in mtdconcat Josh Boyer
2006-05-20 21:19 ` Andrew Morton
2006-05-21 14:32 ` Josh Boyer
2006-05-21 17:04 ` David Woodhouse
2006-05-21 19:03 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox