public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Nicolas Pitre <nico@cam.org>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH,RFC] [MTD] replace MTD_NORFLASH with MTD_GENERIC_TYPE
Date: Tue, 30 May 2006 19:45:52 +0200	[thread overview]
Message-ID: <20060530174552.GE26220@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0605301226001.16927@localhost.localdomain>

On Tue, 30 May 2006 12:32:58 -0400, Nicolas Pitre wrote:
> 
> I'm firmly with you and so far I agree 100% with your effort.  The 
> cleanups you're providing are much appreciated.
> 
> However Artem might have a point.  You probably should leave mtd->type 
> alone, at least for now.  It is good to not depend on it anymore but it 
> probably still has its informative value, just like name string attached 
> to MTD partitions.  If it should go then it should be removed at the 
> very end when no one uses it anymore.

In a way, that is what I do.  mtd->type still exists, although only
for those types that are still used.  MTD_RAM and MTD_ROM have been
converted to MTD_GENERIC_TYPE.  In part, that helps me to easily see
how far I've come with a simple grep.  And in part it prevents others
from reintroducing new dependencies.  My plan is to remove mtd->type
completely when every device is of type MTD_GENERIC_TYPE.

But if there is a general consensus, I can leave that field alone for
now and hope that people don't introduce new dependencies.

Jörn

-- 
It's just what we asked for, but not what we want!
-- anonymous

  parent reply	other threads:[~2006-05-30 17:46 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-30 15:24 [PATCH,RFC] [MTD] replace MTD_NORFLASH with MTD_GENERIC_TYPE Jörn Engel
2006-05-30 15:39 ` Artem B. Bityutskiy
2006-05-30 15:40 ` David Woodhouse
2006-05-30 15:50   ` Jörn Engel
2006-05-30 15:55     ` David Woodhouse
2006-05-30 15:59       ` Jörn Engel
2006-05-30 16:01     ` Artem B. Bityutskiy
2006-05-30 16:10       ` Jörn Engel
2006-05-30 16:32         ` Nicolas Pitre
2006-05-30 16:52           ` Artem B. Bityutskiy
2006-05-30 17:45           ` Jörn Engel [this message]
2006-05-30 18:13             ` Nicolas Pitre
2006-05-30 18:27               ` Jörn Engel
2006-05-30 16:37         ` Artem B. Bityutskiy
2006-05-30 16:57         ` David Woodhouse
2006-05-30 17:08           ` Jörn Engel
2006-05-30 16:42     ` Nicolas Pitre
2006-05-30 18:50 ` Jörn Engel
2006-05-30 18:52   ` David Woodhouse
2006-05-30 19:09     ` Jörn Engel
2006-05-30 19:10   ` Nicolas Pitre
2006-05-30 20:06     ` Jörn Engel
2006-05-31  8:09   ` Artem B. Bityutskiy
2006-05-31 14:01     ` Nicolas Pitre
2006-05-31 14:49       ` Artem B. Bityutskiy
2006-05-31 15:59         ` Nicolas Pitre
2006-05-31 16:45           ` Artem B. Bityutskiy
2006-05-31 17:25             ` Nicolas Pitre
2006-06-01  9:03               ` Artem B. Bityutskiy
2006-06-01 11:33                 ` Jörn Engel
2006-06-01 12:57                   ` Artem B. Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060530174552.GE26220@wohnheim.fh-wedel.de \
    --to=joern@wohnheim.fh-wedel.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox