public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ville Herva <vherva@vianova.fi>
To: "Artem B. Bityutskiy" <dedekind@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: kernel command line arguments for block2mtd do not work
Date: Wed, 5 Jul 2006 10:05:10 +0300	[thread overview]
Message-ID: <20060705070509.GB15078@vianova.fi> (raw)
In-Reply-To: <1152082335.4825.2.camel@sauron.oktetlabs.ru>

On Wed, Jul 05, 2006 at 10:52:15AM +0400, you [Artem B. Bityutskiy] wrote:
> On Tue, 2006-07-04 at 17:38 +0300, Ville Herva wrote:
> > For the rough idea, see 
> >         http://iki.fi/v/tmp/block2mtd.c                      
> > (Sorry for the ugliness - it's just a workaround hack.)
> 
> Hello,
> 
> I'd suggest you to just send a patch. See "Patch submission" at
> http://www.linux-mtd.infradead.org/source.html

I don't think any of the ideas I listed to "fix" the problem are
satisfactory. They all run into the same dead-end of not having access to
the rootfs when parsing the arguments, and hence, not being able to open the
underlying blockdev. 

These days the kernel afaik does not have builtin
device name -> device number mapping (I think it used to - for rootfs
device mounting - but isn't that gone?). The device we are mounting might be
the rootfs, so /dev is not present. Hence, 
	open_bdev_excl(devname, O_RDWR, NULL); 
can't succeed.

What I _was_ able to do (see http://iki.fi/v/tmp/block2mtd.c) is to move the
argument parsing later in boot process - it doesn't fail anymore, but that
doesn't help much, since the device can't be opened. This means the error
message is much more helpful (and it won't crash), but is it worth it?

As a stop-gap measure I suggested making the "out of memory" message more
informative (e.g. "can't parse arguments - not possible from kernel command
line, see Documentation/block2dev.txt" or something.



-- v -- 

v@iki.fi

  reply	other threads:[~2006-07-05  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-04 14:38 kernel command line arguments for block2mtd do not work Ville Herva
2006-07-05  6:52 ` Artem B. Bityutskiy
2006-07-05  7:05   ` Ville Herva [this message]
2006-07-05  7:13     ` Ville Herva
2006-07-05  7:21       ` Artem B. Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060705070509.GB15078@vianova.fi \
    --to=vherva@vianova.fi \
    --cc=dedekind@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox