From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Ville Herva <vherva@vianova.fi>
Cc: linux-mtd@lists.infradead.org, Norbert Federa <nfedera@thinstuff.com>
Subject: Re: block2mtd: Overrun end of disk in cache readahead
Date: Wed, 5 Jul 2006 13:22:23 +0200 [thread overview]
Message-ID: <20060705112223.GA29743@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20060705100727.GC15078@vianova.fi>
On Wed, 5 July 2006 13:07:27 +0300, Ville Herva wrote:
> On Wed, Jul 05, 2006 at 09:49:14AM +0200, you [Norbert Federa] wrote:
> > Ville,
> > Try changing the PAGE_READAHEAD define in
> > /drivers/mtd/devices/block2mtd.c from 64 to 0:
> >
> > -#define PAGE_READAHEAD 64
> > +#define PAGE_READAHEAD 0
>
> Looking at the source, it almost looks like the error message is just a
> spurious warning, not a dangerous error. Doesn't this happen when the
> underlying device does not end at 64k boundary? And the readahead code just
> stops reading ahead after that warning?
I'm fairly tempted to just nuke the readahead code completely. For
some users, it is outright harmful (usbstick, some other flash behind
blockdev interface), for others it should be done by the block device
driver, not by block2mtd.
If either of you wants to do that and can test the resulting patch,
you have my blessing.
Jörn
--
This above all: to thine own self be true.
-- Shakespeare
next prev parent reply other threads:[~2006-07-05 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 7:26 block2mtd: Overrun end of disk in cache readahead Ville Herva
2006-07-05 7:49 ` Norbert Federa
2006-07-05 10:07 ` Ville Herva
2006-07-05 11:22 ` Jörn Engel [this message]
2006-07-06 8:28 ` Ville Herva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705112223.GA29743@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
--cc=nfedera@thinstuff.com \
--cc=vherva@vianova.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox