From: Ville Herva <vherva@vianova.fi>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD] block2mtd.c: Make kernel boot command line arguments work (try 3)
Date: Wed, 12 Jul 2006 20:24:00 +0300 [thread overview]
Message-ID: <20060712172359.GZ15078@vianova.fi> (raw)
In-Reply-To: <20060712095048.GB14333@wohnheim.fh-wedel.de>
On Wed, Jul 12, 2006 at 11:50:48AM +0200, you [Jörn Engel] wrote:
> On Tue, 11 July 2006 09:23:42 +0300, Ville Herva wrote:
> >
> > #ifdef MODULE clutter
>
> Good enough for now. If the klibc discussion ever settles, the early
> initialization code could get moved to userspace.
Good.
One thing I only noticed now, is that while static compile + no boot time
argument test case works, it does unnecessarily printk
error: cannot open device ""
since the argument parsing is invoked even when no argument is supplied.
This is of course harmless, as nothing really happens, but
- ret = block2mtd_setup2(block2mtd_paramline);
+ if (strlen(block2mtd_paramline))
+ ret = block2mtd_setup2(block2mtd_paramline);
might be sensible in block2mtd_init(). (I'm trusting that .initdata and
block2mtd_paramline are zero-initialized.)
-- v --
v@iki.fi
next prev parent reply other threads:[~2006-07-12 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-07 12:22 [PATCH] [MTD] block2mtd.c: Make kernel boot command line arguments work (try 3) Ville Herva
2006-07-10 22:31 ` Ville Herva
2006-07-11 6:23 ` Ville Herva
2006-07-12 9:50 ` Jörn Engel
2006-07-12 17:24 ` Ville Herva [this message]
2006-07-13 13:39 ` Jörn Engel
2006-07-13 13:49 ` Ville Herva
2006-07-13 14:55 ` Jörn Engel
2006-07-13 21:02 ` David Woodhouse
2006-07-13 21:33 ` Ville Herva
2006-07-13 15:41 ` [PATCH] [MTD] block2mtd.c: Remove unnecessary parsing of empty boot-time argument Ville Herva
2006-07-12 9:50 ` [PATCH] [MTD] block2mtd.c: Make kernel boot command line arguments work (try 3) Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712172359.GZ15078@vianova.fi \
--to=vherva@vianova.fi \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox