Re: [PATCH] [MTD] block2mtd.c: Make kernel boot command line arguments work (try 3)

Jörn Engel
2006-07-13T13:40:07Z

On Wed, 12 July 2006 20:24:00 +0300, Ville Herva wrote:
>
> One thing I only noticed now, is that while static compile + no boot time
> argument test case works, it does unnecessarily printk
> error: cannot open device ""
> since the argument parsing is invoked even when no argument is supplied.
> This is of course harmless, as nothing really happens, but
>
> - ret = block2mtd_setup2(block2mtd_paramline);
> + if (strlen(block2mtd_paramline))
> + ret = block2mtd_setup2(block2mtd_paramline);
>
> might be sensible in block2mtd_init(). (I'm trusting that .initdata and
> block2mtd_paramline are zero-initialized.)

Looks sane. Can you send a proper patch for this?

Acked-by: Joern Engel <joern@wohnheim.fh-wedel.de>

Jörn

--
People will accept your ideas much more readily if you tell them
that Benjamin Franklin said it first.
-- unknown