From: Ryan Jackson <rjackson@lnxi.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge
Date: Wed, 25 Oct 2006 11:36:55 -0600 [thread overview]
Message-ID: <20061025173654.GF25530@localdomain> (raw)
In-Reply-To: <1161779958.27622.94.camel@shinybook.infradead.org>
* David Woodhouse <dwmw2@infradead.org> [061025 06:39]:
> This is very reminiscent of the changes you made recently to the
> amd76xrom driver. Can they be merged?
Technically yes, but I'm not totally convinced that makes sense. They
are two completely different southbridges and the registers for each are
different.
The code that loops over the window checking for chips is definitely
generic. The amd76xrom, esb2rom, and the ck804xrom drivers all use it.
Perhaps that bit and anything related could be shared.
> Please fix 'KB' to 'KiB' and 'MB' to 'MiB' if you really mean powers of
> two and not powers of ten.
Okay, I'll change that.
Thanks.
--
Ryan Jackson
Linux Networx
prev parent reply other threads:[~2006-10-25 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 17:46 [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge Ryan Jackson
2006-10-25 11:35 ` Artem Bityutskiy
2006-10-25 16:43 ` Ryan Jackson
2006-10-25 12:39 ` David Woodhouse
2006-10-25 17:36 ` Ryan Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061025173654.GF25530@localdomain \
--to=rjackson@lnxi.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox