Re: [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge

Ryan Jackson
2006-10-25T16:43:48Z

* Artem Bityutskiy <dedekind@infradead.org> [061025 05:35]:
> > + * $Id: ck804xrom.c,v 1.1 2005/01/06 16:58:24 dolsen Exp $
> No need to dubmit CVS stuff

Oops.

> Also it would be nice to add your name at the header.

Sure, but I'm not the original author. I'll put his name in as well as
mine.

> > +#include <linux/config.h>
> Don't include this file - this stuff is done by the Linux build system.

Didn't catch that. I'll remove it.

> > +#define ROM_PROBE_STEP_SIZE (64*1024) /* 64KiB */
> I personally would be happier to see a comment about what this macro is,
> not about that 64*1024 = 64KiB.

Sure.

> {} for one-line operators are not needed as well as all over the code -
> that's a linux coding style convention.

> Please, use } else { instead.

No problem. I should have checked for this already.

Thanks.

--
Ryan Jackson
Linux Networx