Re: [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge

Ryan Jackson
2006-10-25T17:37:02Z

* David Woodhouse <dwmw2@infradead.org> [061025 06:39]:
> This is very reminiscent of the changes you made recently to the
> amd76xrom driver. Can they be merged?

Technically yes, but I'm not totally convinced that makes sense. They
are two completely different southbridges and the registers for each are
different.

The code that loops over the window checking for chips is definitely
generic. The amd76xrom, esb2rom, and the ck804xrom drivers all use it.
Perhaps that bit and anything related could be shared.

> Please fix 'KB' to 'KiB' and 'MB' to 'MiB' if you really mean powers of
> two and not powers of ten.

Okay, I'll change that.

Thanks.

--
Ryan Jackson
Linux Networx