Re: [PATCH] [PATCH] [MTD] MAPS: Support for BIOS flash chips on the nvidia ck804 southbridge

Artem Bityutskiy
2006-10-25T11:35:14Z

Hello Ryan,

please, find few of my minor notes below:

> +/*
> + * ck804xrom.c
> + *
> + * Normal mappings of chips in physical memory
> + * $Id: ck804xrom.c,v 1.1 2005/01/06 16:58:24 dolsen Exp $
No need to dubmit CVS stuff
Also it would be nice to add your name at the header.

> + */

> +#include <linux/config.h>
Don't include this file - this stuff is done by the Linux build system.

> +#define MOD_NAME KBUILD_BASENAME
> +
> +#define ADDRESS_NAME_LEN 18
> +
> +#define ROM_PROBE_STEP_SIZE (64*1024) /* 64KiB */
I personally would be happier to see a comment about what this macro is,
not about that 64*1024 = 64KiB.

> + /* Free all of the mtd devices */
> + list_for_each_entry_safe(map, scratch, &window->maps, list) {
> + if (map->rsrc.parent) {
> + release_resource(&map->rsrc);
> + }
{} for one-line operators are not needed as well as all over the code -
that's a linux coding style convention.

> + pci_write_config_byte(pdev, 0x88, byte | (1<<6));
> + }
> + else {
> + window->phys = 0xffff0000; /* 64KiB */
Please, use } else { instead.

--
Best regards,
Artem Bityutskiy (Битюцкий Артём)