Re: Fw: Top 100 inline functions (make allyesconfig) was Re: [ANNOUNCE] pahole and other DWARF2 utilities

Re: Fw: Top 100 inline functions (make allyesconfig) was Re: [ANNOUNCE] pahole and other DWARF2 utilities

[David Woodhouse]

On Sat, 2006-11-04 at 13:20 -0800, Andrew Morton wrote:
> cfi_build_cmd() is nutty. 

Damn right it's nutty. Imagine the number of ways you can wire up 1-8
flash chips in either 8-bit or 16-bit mode to a bus which is between 8
and 64 bits wide. Deal with it in software, with a "chip driver"
abstraction which knows what data to put at which address on each
_chip_, and which needs to calculate the corresponding bus data/address.

In the sensible case where you build in support for what you have -- one
interleave, one mode, one bus size -- it's simple. And that's why it's
inline. This is one of the cases where 'allyesconfig' just doesn't make
much sense.

I'm not entirely averse to taking it out-of-line, but show me data on
the interesting case rather than the allyesconfig case.

And tell me about it in about two weeks' time when the sky stops falling
on my head and I get to go home. :)

-- 
dwmw2

Re: Fw: Top 100 inline functions (make allyesconfig) was Re: [ANNOUNCE] pahole and other DWARF2 utilities

[Arnaldo Carvalho de Melo]

On Sun, Nov 05, 2006 at 02:32:17PM +0800, David Woodhouse wrote:
> On Sat, 2006-11-04 at 13:20 -0800, Andrew Morton wrote:
> > cfi_build_cmd() is nutty. 
> 
> Damn right it's nutty. Imagine the number of ways you can wire up 1-8
> flash chips in either 8-bit or 16-bit mode to a bus which is between 8
> and 64 bits wide. Deal with it in software, with a "chip driver"
> abstraction which knows what data to put at which address on each
> _chip_, and which needs to calculate the corresponding bus data/address.
> 
> In the sensible case where you build in support for what you have -- one
> interleave, one mode, one bus size -- it's simple. And that's why it's
> inline. This is one of the cases where 'allyesconfig' just doesn't make
> much sense.
> 
> I'm not entirely averse to taking it out-of-line, but show me data on
> the interesting case rather than the allyesconfig case.

See my Answer to Adrian, it was just extreme testing the tools, I'll use
config files shipped by distros to get even more interesting and down to
earth results.

- Arnaldo