From: Alexander Schmidt <alexs@linux.vnet.ibm.com>
To: "Artem, " <dedekind@infradead.org>
Cc: "linux-mtd@lists.infradead.org, " <linux-mtd@lists.infradead.org>
Subject: [PATCH] UBI: fix errorhandling in ioctl
Date: Mon, 18 Dec 2006 13:57:35 +0100 [thread overview]
Message-ID: <200612181357.35365.alexs@linux.vnet.ibm.com> (raw)
Hi,
the double declaration of "int err" makes the ioctl() for resizing volumes
always return 0, even if errors occured during the resizing procedure.
I hope the patch applies this time, i double checked it...
Kind regards,
Alexander Schmidt
Signed-off-by: Alexander Schmidt, <alexs@linux.vnet.ibm.com>
---
diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c
index 469cc47..be304dc 100644
--- a/drivers/mtd/ubi/cdev.c
+++ b/drivers/mtd/ubi/cdev.c
@@ -824,7 +824,7 @@ out_free:
/* Re-size volume command */
case UBI_IOCRSVOL:
{
- int err, rem, pebs;
+ int rem, pebs;
uint64_t tmp;
const struct ubi_vtbl_vtr *vtr;
struct ubi_rsvol_req req;
next reply other threads:[~2006-12-18 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 12:57 Alexander Schmidt [this message]
2006-12-18 14:16 ` [PATCH] UBI: fix errorhandling in ioctl Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612181357.35365.alexs@linux.vnet.ibm.com \
--to=alexs@linux.vnet.ibm.com \
--cc=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox