From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Stefan Roese <ml@stefan-roese.de>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] [MTD] physmap: Add support for 64 bit resources on PPC44x
Date: Fri, 19 Jan 2007 00:59:00 +0100 [thread overview]
Message-ID: <20070118235900.GA23974@xi.wantstofly.org> (raw)
In-Reply-To: <200701181808.11143.ml@stefan-roese.de>
On Thu, Jan 18, 2007 at 06:07:53PM +0100, Stefan Roese wrote:
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -116,7 +116,14 @@ static int physmap_flash_probe(struct platform_device
> *dev)
> info->map.bankwidth = physmap_data->width;
> info->map.set_vpp = physmap_data->set_vpp;
>
> +#ifdef CONFIG_44x
> + if (sizeof(dev->resource->start) == 4)
CONFIG_RESOURCES_64BIT
> + info->map.virt = ioremap(info->map.phys, info->map.size);
> + else
> + info->map.virt = ioremap64(dev->resource->start, info->map.size);
> +#else
> info->map.virt = ioremap(info->map.phys, info->map.size);
> +#endif
Ugh. Do you have crap like this everywhere ioremap() is called?
Why can't you fix ioremap() to take >= 4G addresses instead?
next prev parent reply other threads:[~2007-01-18 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 17:07 [PATCH] [MTD] physmap: Add support for 64 bit resources on PPC44x Stefan Roese
2007-01-18 17:24 ` Sergei Shtylyov
2007-01-18 17:46 ` Stefan Roese
2007-01-18 23:59 ` Lennert Buytenhek [this message]
2007-01-19 1:29 ` Josh Boyer
2007-01-19 7:35 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070118235900.GA23974@xi.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ml@stefan-roese.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox